Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 6123 - portagemaster-0.1.8.ebuild (Update)
Summary: portagemaster-0.1.8.ebuild (Update)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: x86 Linux
: High enhancement (vote)
Assignee: Karl Trygve Kalleberg (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on: 4601
Blocks:
  Show dependency tree
 
Reported: 2002-08-06 19:13 UTC by milosn
Modified: 2003-02-04 19:42 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
portagemaster-0.1.8.ebuild (Update) (portagemaster-0.1.8.ebuild,820 bytes, text/plain)
2002-08-06 19:14 UTC, milosn
Details
portagemaster-0.1.8-r1.ebuild (Update) (portagemaster-0.1.8-r1.ebuild,840 bytes, text/plain)
2002-08-08 17:34 UTC, milosn
Details

Note You need to log in before you can comment on or make changes to this bug.
Description milosn 2002-08-06 19:13:24 UTC
I am not sure if "virtual/jdk-1.4" issue has been resolved so i am linking it
against ">=dev-java/sun-jdk-1.4".
Also since there have been changes in portage output format this version works
with portage-2.0.25(and later if there are no new changes), so
">=sys-apps/portage-2.0.25" is in RDEPEND.
Comment 1 milosn 2002-08-06 19:14:40 UTC
Created attachment 2881 [details]
portagemaster-0.1.8.ebuild (Update)
Comment 2 milosn 2002-08-06 20:21:16 UTC
"That is one solution, but for now I'd prefer to just make the affected packages
dependent on Sun's jdk/jre.  Bigger fish to fry in the Portage code at the
moment.  I'll leave this bug open as an enhancement request and get to it when I
can get to it, which may not be soon.  For now, just switch those guys over to
depend on Sun's stuff."
By D. Robbins in response to "virtual/jdk-1.4" issue



thats what i did...why is this blocked again???

Milos
Comment 3 Karl Trygve Kalleberg (RETIRED) gentoo-dev 2002-08-07 17:15:26 UTC
I can't reproduce the "blocking" you are referring to, if you give me details, 
I can hopefully help.

I've looked over the ebuild you submitted. We have made a good deal of changes 
to how our ebuilds work lately. I'm sorry we have not spent enough time 
evangelising our changes to our external contributors. 

The following is a list of issues I found. As you can see, all a minor hiccups:

1) It not pass lintool:
* Testing for presence of env vars                                      : failed
- (E) Missing LICENSE=
- (W) Missing SLOT=

You must add
LICENSE="GPL" or whatever license portagemaster is supplied under
SLOT="0"
KEYWORDS="x86" or whatever platform you _know_ it works on. If you haven't 
tested it on a particular platform, that platform should not go into the 
keywords. This holds true for Java apps as well.

2) The build is missing the
# $Header:$
that's part of the header in skel.ebuild, please add it.

3) Packages should _not_ touch files inside /root. Why do you 
create /root/.${PN} ? 

4) src_unpack(), as written in the build, is completely superflous; that is 
exactly what the default src_unpack does. Please remove it, to avoid excess 
bloat.

If you fix these bugs, then upload a new a .ebuild (or a diff), _AND_ a 
ChangeLog with it, I'll commit it asap.

Wrt to the virtual/jdk stuff, you can safely depend directly on dev-java/sun-
jdk-1.4.x for now.
Comment 4 milosn 2002-08-08 17:34:33 UTC
Created attachment 2935 [details]
portagemaster-0.1.8-r1.ebuild (Update)

hmmm i think ive fixed everything except the "/root/.${PN}" directory. It is
created to store configuration file, and since portageMaster is intended to be
run by "root", I thought that's the place for it. If the directory is not there
user will be prompted to create it manualy.
I would like to leave it like this for now, and ill fix the portageMaster so
that "/root/portagemaster/" is not needed any more.

Milos
Comment 5 Karl Trygve Kalleberg (RETIRED) gentoo-dev 2002-09-08 15:37:42 UTC
Yours and Robin Cull's submission were virtually identical. I rewrote his
(random pick) and added it. Available as: app-admin/portagemaster-0.1.8.