Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 611210 - x11-misc/sddm-0.14.0-r2: faulty Xsession w.r.t consolekit
Summary: x11-misc/sddm-0.14.0-r2: faulty Xsession w.r.t consolekit
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: LxQt maintainers
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2017-02-28 14:40 UTC by Joakim Tjernlund
Modified: 2017-10-21 19:48 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Xsession DBUS/ConsoleKit fix (sddm.patch,544 bytes, patch)
2017-10-09 15:11 UTC, Joakim Tjernlund
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joakim Tjernlund 2017-02-28 14:40:32 UTC
Looking at sddm's Xsession script we have:

# run all system xinitrc shell scripts.
if [ -d /etc/X11/xinit/xinitrc.d ]; then
  for i in /etc/X11/xinit/xinitrc.d/* ; do
  if [ -x "$i" ]; then
    . "$i"
  fi
  done
fi

....

if [ -z "$@" ]; then
    exec xmessage -center -buttons OK:0 -default OK "Sorry, $DESKTOP_SESSION is no valid session."
else
    exec ck-launch-session $@
fi

This seems wrong to me. The scripts in /etc/X11/xinit/xinitrc.d/ adjust for
consolekit fixes the "command" variable to match. To pick this up Xsession should read(and consolekit USE flag to be removed):

#Make DBUS start optimally
command="$@"

# run all system xinitrc shell scripts.
if [ -d /etc/X11/xinit/xinitrc.d ]; then
  for i in /etc/X11/xinit/xinitrc.d/* ; do
  if [ -x "$i" ]; then
    . "$i"
  fi
  done
fi

....

if [ -z "$@" ]; then
    exec xmessage -center -buttons OK:0 -default OK "Sorry, $DESKTOP_SESSION is no valid session."
else
    exec $command
fi
Comment 1 Joakim Tjernlund 2017-02-28 15:15:20 UTC
See also
  https://bugs.gentoo.org/show_bug.cgi?id=533456
Comment 2 Joakim Tjernlund 2017-05-12 10:32:54 UTC
ping?
Comment 3 Joakim Tjernlund 2017-10-03 07:14:32 UTC
(In reply to Joakim Tjernlund from comment #2)
> ping?

Pleas fix, I am getting really tired of manually fixing this every time
sddm gets rebuilt.
Comment 4 Joakim Tjernlund 2017-10-09 15:11:46 UTC
Created attachment 498228 [details, diff]
Xsession DBUS/ConsoleKit fix
Comment 5 Joakim Tjernlund 2017-10-09 16:06:51 UTC
sddm-0.16 is broken for me. Seem like this version has native support
for consolekit but whatever I do I get:

[17:50:18.480] (II) DAEMON: Initializing...
[17:50:18.487] (II) DAEMON: Console kit interface found
[17:50:18.487] (WW) DAEMON: QDBusConnection: error: could not send message to service "org.freedesktop.ConsoleKit" path "/org/freedesktop/ConsoleKit/Manager" interface "/org.freedesktop.ConsoleKit.Manager" member "ListSeats": Invalid interface class: /org.freedesktop.ConsoleKit.Manager
[17:50:18.487] (II) DAEMON: Starting...
Comment 6 Andreas Sturmlechner gentoo-dev 2017-10-21 19:48:11 UTC
Thanks, should be fixed in -r2, git commit 43b42afbcdf73e9dc819938fb6ed4c8d289beecb.