Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 610918 - www-client/firefox-51.0.1 unneeded dependeny on media-libs/harfbuzz[icu,graphite] with system-harfbuzz
Summary: www-client/firefox-51.0.1 unneeded dependeny on media-libs/harfbuzz[icu,graph...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Mozilla Gentoo Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-25 20:37 UTC by Ostashevskyi Viktor
Modified: 2017-03-20 14:59 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ostashevskyi Viktor 2017-02-25 20:37:04 UTC
Grepping through sources doesn't shows any usages of hg_grahite2_* or hb_icu_* functions.

However, Firefox uses graphite2 directly, so it makes sense to add direct dependency on media-gfx/graphite2.
Comment 1 Ostashevskyi Viktor 2017-02-26 17:57:47 UTC
Confirmed by building firefox:

eme
Comment 2 Ostashevskyi Viktor 2017-02-26 18:01:32 UTC
Confirmed by building firefox:

equery u harfbuzz
[ Legend : U - final flag setting for installation]
[        : I - package is installed with flag     ]
[ Colors : set, unset                             ]
 * Found these USE flags for media-libs/harfbuzz-1.4.2:
 U I
 - - abi_x86_32    : 32-bit (x86) libraries
 - - cairo         : Enable support for the cairo graphics library
 - - fontconfig    : Support for configuring and customizing font access via media-libs/fontconfig
 + + glib          : Compile with GLib Unicode support
 - - graphite      : Use graphite to render complex non-Roman writing systems
 - - icu           : Enable ICU (Internationalization Components for Unicode) support, using dev-libs/icu
 - - introspection : Add support for GObject based introspection
 - - static-libs   : Build static versions of dynamic libraries as well
 - - test          : Workaround to pull in packages needed to run with FEATURES=test. Portage-2.1.2 handles this internally, so don't
                     set it in make.conf/package.use anymore
 + + truetype      : Add support for FreeType and/or FreeType2 fonts

emerge -v1 --nodeps firefox


Builds cleanly.
Comment 3 Ian Stakenvicius (RETIRED) gentoo-dev 2017-02-27 15:30:06 UTC
I'll need to check how mozilla configures its bundled copy of harfbuzz to confirm whether we can drop this or not -- even if there are no direct calls of hg_icu_* or hg_graphite2_* functions doesn't mean they don't expect said support to exist (and will use it in future releases) or allow extensions to use it.

I'll aim to sort this out before the 52.0 release occurrs.
Comment 4 Ostashevskyi Viktor 2017-02-27 18:27:40 UTC
(In reply to Ian Stakenvicius from comment #3)
> I'll need to check how mozilla configures its bundled copy of harfbuzz to
> confirm whether we can drop this or not -- even if there are no direct calls
> of hg_icu_* or hg_graphite2_* functions doesn't mean they don't expect said
> support to exist (and will use it in future releases) or allow extensions to
> use it.
> 
> I'll aim to sort this out before the 52.0 release occurs.

Makes sense, but it could happen that they've used to configure bundled harfbuzz with icu and graphite2 because it was used previously, but not now.
Comment 5 Ian Stakenvicius (RETIRED) gentoo-dev 2017-03-20 14:57:26 UTC
DEFINES['HB_NO_UNICODE_FUNCS'] = True

..in the moz.build I think confirms this.  Firefox-52.0 will not depend on system-icu / system-harfbuzz[icu] synchronization.