Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 61072 - a patch to the doomsday-1.8.0 ebuild to fix ambient light problems
Summary: a patch to the doomsday-1.8.0 ebuild to fix ambient light problems
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Games (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Gentoo Games
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-08-20 13:28 UTC by Pkunk
Modified: 2004-09-03 05:59 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
file goes in /usr/portage/games-fps/doomsday (doomsday-1.8.0-r1.ebuild,1.15 KB, application/octet-stream)
2004-08-20 13:29 UTC, Pkunk
Details
file goes in /usr/portage/games-fps/doomsday/files (1.8.0-ambient-light.patch,439 bytes, application/octet-stream)
2004-08-20 13:31 UTC, Pkunk
Details
doomsday-1.8.1 ebuild with ambient light patch (doomsday-1.8.1.ebuild,1.16 KB, text/plain)
2004-08-20 18:28 UTC, Pkunk
Details
Updated ambient patch for doomsday v1.81 (1.8.1-ambient-light.patch,485 bytes, patch)
2004-08-20 18:30 UTC, Pkunk
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pkunk 2004-08-20 13:28:37 UTC
By default doomsday sets ambient light to 0 , which makes the game unplayable as its too dark.
Even if you change the settings in panel it keeps resetting it back 0.
This patch forces ambient light level to 200 which is ideal for almost all users and make doom look more like the real doom , than like doom3.


Reproducible: Always
Steps to Reproduce:
1.
2.
3.




Attaching new ebuild and .patch file to this bug report
Comment 1 Pkunk 2004-08-20 13:29:54 UTC
Created attachment 37817 [details]
file goes in /usr/portage/games-fps/doomsday

updated ebuild with ambient light patch
Comment 2 Pkunk 2004-08-20 13:31:04 UTC
Created attachment 37818 [details]
file goes in /usr/portage/games-fps/doomsday/files

the ambient-light patch file
Comment 3 Chris Gianelloni (RETIRED) gentoo-dev 2004-08-20 14:30:22 UTC
Did you also submit this upstream?  *grin*
Comment 4 Pkunk 2004-08-20 18:28:45 UTC
Created attachment 37835 [details]
doomsday-1.8.1 ebuild with ambient light patch

While i was at it , the doomsday team have just released v1.81

This is the 1.81 ebuild with the ambient light patch attached next.
Comment 5 Pkunk 2004-08-20 18:30:39 UTC
Created attachment 37836 [details, diff]
Updated ambient patch for doomsday v1.81

This patch with lock minimum ambience at 200.

If the user sets it to a higher level it will no longer reset it to 200.
Comment 6 Chris Gianelloni (RETIRED) gentoo-dev 2004-08-31 15:18:21 UTC
Added to CVS... thanks for the patch!

I also submitted this upstream to the authors.
Comment 7 Chris Gianelloni (RETIRED) gentoo-dev 2004-09-01 06:57:11 UTC
I just received an email from the package author, asking that I do *not* include this patch into the ebuild.

Here is the email:

From: 	Jaakko Ker
Comment 8 Chris Gianelloni (RETIRED) gentoo-dev 2004-09-01 06:57:11 UTC
I just received an email from the package author, asking that I do *not* include this patch into the ebuild.

Here is the email:

From: 	Jaakko Keränen <jaakko.keranen@iki.fi>
To: 	wolf31o2@gentoo.org
Subject: 	Re: Ambient Light patch for Doomsday 1.8.1
Date: 	Wed, 1 Sep 2004 16:23:41 +0300	
On Sep 1, 2004, at 1:23, Chris Gianelloni wrote:
> This patch was submitted to bug #61072 at bugs.gentoo.org and solves a
> problem with ambient lighting being too dark.

I was not aware that such a problem even existed. Anyway, what the 
patch does is unacceptable. The ambient light level is supposed to be 
zero during normal game play and is only intended for debugging because 
it breaks the Doom lighting model. Perhaps the patch submitter was 
really looking for a way to increase display brightness, like with the 
color settings (gamma, contrast, brightness) in the Control Panel 
(which have been working using SDL since Doomsday 1.8.1).

I ask that you do not include this patch in the Gentoo Doomsday package.

Regards,
--
Jaakko Keränen
http://www.iki.fi/code/


Due to this request, I am going to remove the patch, and resolve this bug as WONTFIX.
Comment 9 Chris Gianelloni (RETIRED) gentoo-dev 2004-09-01 06:57:26 UTC
Patch reverted...
Comment 10 Pkunk 2004-09-02 23:30:55 UTC
Sorry if my patch offended the Author.

I had made this on my machine in for doomsday 1.8.0 because the brightness controls were not working with an older nvidia driver .

However in doomsday 1.8.1 this problem is fixed and the brightness slider works very well.
Comment 11 Chris Gianelloni (RETIRED) gentoo-dev 2004-09-03 05:59:42 UTC
No problem... it was apparently a problem with 1.8.0, but he had already made changes that would negate the need for your patch for 1.8.1... it happens.