Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 610444 - =app-admin/conky-1.10.6: text shadows not being drawn
Summary: =app-admin/conky-1.10.6: text shadows not being drawn
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Daniel Pielmeier
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-22 02:27 UTC by zlg (RETIRED)
Modified: 2017-11-18 11:32 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
conky-1.10.6-fix-text-shades.patch (conky-1.10.6-fix-text-shades.patch,401 bytes, patch)
2017-02-22 02:29 UTC, zlg (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zlg (RETIRED) gentoo-dev 2017-02-22 02:27:52 UTC
Problem
-------
When using a few configuration options (listed below), conky should be casting shadows on text so it has a "3D" look to it. This aids in readability for light-colored fonts on light-colored backgrounds. Version 1.10.6 doesn't do this.

Relevant config options
-----------------------
~/.conkyrc:

conky.config = {
    default_color = 'ffffff',
    default_shade_color = '333333',
    draw_shades = true,
}

conky.text = [[
This should be white text with a gray shadow
]]

Expectation
-----------

conky should be displaying the text as white with a gray shadow.

Reality
-------

Text gets displayed as plain white.

Cause
-----

In src/conky.cc's draw_stuff() function, there are two local variables that are created and initialized to zero, forcing the shadow to not be offset as it should be. Hiding this behind an '#ifndef BUILD_X11' section fixes this, as it appears to be an oversight when a refactor was done in recent months.

I have attached the patch I wrote to fix this, after finding the upstream issue [1]. Upstream has not yet committed a fix.

[1]: https://github.com/brndnmtthws/conky/issues/331
Comment 1 zlg (RETIRED) gentoo-dev 2017-02-22 02:29:46 UTC
Created attachment 464586 [details, diff]
conky-1.10.6-fix-text-shades.patch
Comment 2 Daniel Pielmeier gentoo-dev 2017-02-22 06:02:56 UTC
Thanks for the report. The reason this has not fixed upstream is probably that no pull request was opened for it. I went ahead and created one. Let's see if this speeds things up.
Comment 3 Daniel Pielmeier gentoo-dev 2017-11-18 11:32:24 UTC
Fixed in GIT.