Created attachment 464544 [details] eric-17.02.1.ebuild Latest version of eric is 17.02.1. Eric both works with qt4 and qt5 but currently the ebuild supports only qt4. One of the deps is qscintilla-python (and then qscintilla) which are built with +qt4. This conflicts with other packages (e.g. octave[gui]) which require qscintilla to be built with +qt5. I have changed the ebuild to have the change to select both qt4 or qt5, please evaluate it.
Thanks for your work, please attach a diff over the latest ebuild instead.
Here is the diff --- /usr/portage/dev-util/eric/eric-17.01.ebuild 2017-01-21 23:07:36.000000000 +0100 +++ /var/lib/layman/__mine__/dev-util/eric/eric-17.02.1.ebuild 2017-02-21 16:34:43.913918782 +0100 @@ -17,13 +17,20 @@ MY_P=${PN}${SLOT}-${PV} SRC_URI="mirror://sourceforge/eric-ide/${PN}${SLOT}/stable/${PV}/${MY_P}.tar.gz" KEYWORDS="~amd64 ~ppc ~ppc64 ~x86" -IUSE="" +IUSE="qt4 qt5" +REQUIRED_USE="^^ (qt4 qt5)" DEPEND=" ${PYTHON_DEPS} >=dev-python/sip-4.14.3[${PYTHON_USEDEP}] - >=dev-python/PyQt4-4.10[${PYTHON_USEDEP},X,help,sql,svg,webkit] - >=dev-python/qscintilla-python-2.8[qt4(+),${PYTHON_USEDEP}] + qt4? ( + >=dev-python/PyQt4-4.10[${PYTHON_USEDEP},X,help,sql,svg,webkit] + >=dev-python/qscintilla-python-2.8[qt4(+),-qt5,${PYTHON_USEDEP}] + ) + qt5? ( + >=dev-python/PyQt5-5.5.1[${PYTHON_USEDEP},help,sql,svg,webkit] + >=dev-python/qscintilla-python-2.8[-qt4,qt5(+),${PYTHON_USEDEP}] + ) " RDEPEND="${DEPEND} >=dev-python/chardet-2.3.0[${PYTHON_USEDEP}] @@ -60,7 +67,7 @@ -i "${D}" \ -c \ -z \ - --pyqt=4 \ + $(use qt4 && echo --pyqt=4) \ || die python_optimize
Created attachment 464548 [details, diff] eric.diff
You're introducing two use flags when one is enough. ;) If there is any compelling reason to keep the Qt4 option, then just add USE=+qt5 and let the Qt4 magic happen if "-qt5" is set. qscintilla-python ebuild already requires "^^ ( qt4 qt5 )" so you don't have to juggle with both flags. Re configure, the default is Qt5 if --pyqt is not passed at all?
(In reply to Andreas Sturmlechner from comment #4) > You're introducing two use flags when one is enough. ;) If there is any > compelling reason to keep the Qt4 option, then just add USE=+qt5 and let the > Qt4 magic happen if "-qt5" is set. I have followed other ebuilds where there is a mutually exclusive qt4 vs qt5 distinction. I like more the explicit version which clearly states if qt4 or qt5 is used, IMHO if -qt5 is set it's not evident that qt4 will be used until emerge is run. > qscintilla-python ebuild already requires "^^ ( qt4 qt5 )" so you don't have > to juggle with both flags. > > Re configure, the default is Qt5 if --pyqt is not passed at all? It seems that PtQy5 is the first option with autodetection
(In reply to Fabio Rossi from comment #5) > I have followed other ebuilds where there is a mutually exclusive qt4 vs qt5 > distinction. I like more the explicit version which clearly states if qt4 or > qt5 is used, IMHO if -qt5 is set it's not evident that qt4 will be used > until emerge is run. Qt project policy: https://wiki.gentoo.org/wiki/Project:Qt/Policies#Requires_one_of_two_Qt_versions I only except ^^ ( qt4 qt5 ) for libraries that have existing reverse dependencies. That is painful enough, but we need not bother users with an emerge blocker that can be so easily avoided.
just drop qt4 altogether and keep only the qt5 "option"
Created attachment 464674 [details, diff] eric.diff Here is a new version using only the qt5 useflag
Sorry, I meant drop qt4 support completely, and only allow building against qt5. I don't see any reasons to keep qt4 around.
Created attachment 465268 [details, diff] eric.diff
(In reply to Andreas Sturmlechner from comment #4) > qscintilla-python ebuild already requires "^^ ( qt4 qt5 )" so you don't have > to juggle with both flags. Please fix the qscintilla-python use deps as described above. qscintilla-python is handling qt4 vs. 5 itself, so there's no need for you to force off qt4; should it be possible at some point for both flags to be enabled, eric shall not stand in its way.
Also, qt5(+) is wrong in that context, as previous qscintilla-python versions clearly did not have qt5 support if they were lacking the use flag. 'qt5' is enough.
Created attachment 465288 [details, diff] eric.diff
Created attachment 465290 [details, diff] eric.diff hopefully last :-)
Thanks, bumped in git. I saw there was a new version so bumped straight to that, and added a couple of extra USE flags for PyQt5 that I noticed in the install file. https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=41b48133d6c301cd411b3637689a3abfdf5e43a0
