Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 609578 - sci-libs/openfoam-2.4.0 - add patch for compatibility with flex-2.6
Summary: sci-libs/openfoam-2.4.0 - add patch for compatibility with flex-2.6
Status: RESOLVED OBSOLETE
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Deadline: 2019-10-28
Assignee: Patrick Lauer
URL:
Whiteboard:
Keywords: PATCH, PMASKED
Depends on:
Blocks: flex-2.6.2
  Show dependency tree
 
Reported: 2017-02-16 21:19 UTC by Richard Kenney
Modified: 2019-10-31 15:36 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Patch to provide compatibility with flex-2.6 (openfoam-2.4.0-flex.patch,5.07 KB, patch)
2017-02-16 21:19 UTC, Richard Kenney 		Details | Diff
Revised ebuild incorporating patch (openfoam-2.4.0-r2.ebuild,3.14 KB, text/plain)
2017-02-16 21:20 UTC, Richard Kenney 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Richard Kenney 2017-02-16 21:19:16 UTC 
Created attachment 464020 [details, diff]
Patch to provide compatibility with flex-2.6

OpenFOAM-2.4.0 fails to compile executables with the current stable version of flex (sys-devel/flex-2.6.1). Note that the compilation failure is silent - the ebuild appears to complete successfully but fails to install any executables and errors can be seen in the build.log file

This problem has been found & corrected upstream for later versions of OpenFOAM:
https://bugs.openfoam.org/view.php?id=1974

Attached is a patch to implement the fix for OpenFOAM-2.4.0 and a revised ebuild which I have tested.
Comment 1 Richard Kenney 2017-02-16 21:20:01 UTC 
Created attachment 464024 [details]
Revised ebuild incorporating patch
Comment 2 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2017-05-08 13:44:53 UTC 
Is this still an issue with =sys-devel/flex-2.6.4 package?
Comment 3 Richard Kenney 2017-05-09 12:07:08 UTC 
(In reply to Lars Wendler (Polynomial-C) from comment #2)
> Is this still an issue with =sys-devel/flex-2.6.4 package?

Yes.

The patch improves an incomplete version check.  Without it only the subminor version is checked (so anything with a subminor version < x.x.34 is interpreted as 'old'), causing ongoing problems from the numbering rollover from 2.5.39 to 2.6.0. The patch adds a minor version check so that the current releases are correctly handled.
Comment 4 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2019-10-31 15:36:48 UTC 
Package removed.