Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 609258 - www-plugins/nspluginwrapper-1.4.4-r3 : /.../struct_timespec.h:8:8: error: redefinition of ‘struct timespec’
Summary: www-plugins/nspluginwrapper-1.4.4-r3 : /.../struct_timespec.h:8:8: error: red...
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Patrick McLean
URL:
Whiteboard:
Keywords: PMASKED
Depends on:
Blocks:
 
Reported: 2017-02-13 13:21 UTC by Toralf Förster
Modified: 2017-04-17 07:53 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge-info.txt (emerge-info.txt,5.80 KB, text/plain)
2017-02-13 13:21 UTC, Toralf Förster
Details
emerge-history.txt (emerge-history.txt,225.49 KB, text/plain)
2017-02-13 13:21 UTC, Toralf Förster
Details
environment (environment,100.47 KB, text/plain)
2017-02-13 13:21 UTC, Toralf Förster
Details
etc.portage.tbz2 (etc.portage.tbz2,14.83 KB, application/x-bzip)
2017-02-13 13:21 UTC, Toralf Förster
Details
www-plugins:nspluginwrapper-1.4.4-r3:20170213-125110.log (www-plugins:nspluginwrapper-1.4.4-r3:20170213-125110.log,10.04 KB, text/plain)
2017-02-13 13:21 UTC, Toralf Förster
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Toralf Förster gentoo-dev 2017-02-13 13:21:42 UTC
                 from /var/tmp/portage/www-plugins/nspluginwrapper-1.4.4-r3/work/nspluginwrapper-1.4.4/src/sysdeps.h:39,
                 from /var/tmp/portage/www-plugins/nspluginwrapper-1.4.4-r3/work/nspluginwrapper-1.4.4/src/npw-viewer.c:23:
/usr/include/bits/types/struct_timespec.h:8:8: error: redefinition of ‘struct timespec’
 struct timespec
        ^
In file included from /var/tmp/portage/www-plugins/nspluginwrapper-1.4.4-r3/work/nspluginwrapper-1.4.4/lsb-build/headers/unistd.h:5:0,

  -----------------------------------------------------------------

  This is an unstable amd64 chroot image (named plasma-unstable_20170206-210542) at a hardened host acting as a tinderbox.

  -----------------------------------------------------------------

gcc-config -l:
 [1] x86_64-pc-linux-gnu-5.4.0 *
llvm-config --version:
3.9.1
Available Java Virtual Machines:
  [1]   icedtea-bin-8  system-vm
Available Python interpreters, in order of preference:
  [1]   python3.4
  [2]   python2.7 (fallback)
  [3]   jython2.7 (fallback)
Available Ruby profiles:
  [1]   ruby21 (with Rubygems) *
java-config:
The following VMs are available for generation-2:
*)	IcedTea JDK 3.3.0 [icedtea-bin-8]
Comment 1 Toralf Förster gentoo-dev 2017-02-13 13:21:45 UTC
Created attachment 463602 [details]
emerge-info.txt
Comment 2 Toralf Förster gentoo-dev 2017-02-13 13:21:48 UTC
Created attachment 463604 [details]
emerge-history.txt
Comment 3 Toralf Förster gentoo-dev 2017-02-13 13:21:51 UTC
Created attachment 463606 [details]
environment
Comment 4 Toralf Förster gentoo-dev 2017-02-13 13:21:54 UTC
Created attachment 463608 [details]
etc.portage.tbz2
Comment 5 Toralf Förster gentoo-dev 2017-02-13 13:21:57 UTC
Created attachment 463610 [details]
www-plugins:nspluginwrapper-1.4.4-r3:20170213-125110.log
Comment 6 David Seifert gentoo-dev 2017-03-12 18:04:12 UTC
commit 84cb36ea9322b2cfb6a87db18b9d51f38908fb17
Author: David Seifert <soap@gentoo.org>
Date:   Sun Mar 12 18:59:11 2017 +0100

    profiles: Mask www-plugins/nspluginwrapper for removal
    
    Bug: https://bugs.gentoo.org/show_bug.cgi?id=609258
Comment 7 Michael Palimaka (kensington) gentoo-dev 2017-03-16 08:34:00 UTC
Since this package is being removed, it no longer blocks stabilisation.
Comment 8 Mark (voidzero) 2017-03-20 12:08:51 UTC
The removal of nspluginwrapper might be problematic for one specific (but, for us, sadly very important) application: icaclient. This is the Cytrix "remote desktop" interface that allows us to work from home.

Would icaclient still work from the browser without nsplugin? I'm not sure to be honest.

I can also just copy the current nspluginwrapper ebuild into my local repository, but for other users the removal (thus icaclient breakage) might come at a very inconvenient time. One example is my wife: for her as a medical doctor icaclient is crucial during night and weekend shifts. At those times, whenever a crisis occurs it's very important that icaclient does work.

So I hope this can be considered.
Comment 9 Mark (voidzero) 2017-04-02 15:28:19 UTC
The '30 days until removal' window is approaching. Could someone please comment on what I said regarding icaclient? It's very important. Thanks.
Comment 10 David Seifert gentoo-dev 2017-04-02 15:45:57 UTC
(In reply to Mark (voidzero) from comment #8)
> The removal of nspluginwrapper might be problematic for one specific (but,
> for us, sadly very important) application: icaclient. This is the Cytrix
> "remote desktop" interface that allows us to work from home.
> 
> Would icaclient still work from the browser without nsplugin? I'm not sure
> to be honest.
> 
> I can also just copy the current nspluginwrapper ebuild into my local
> repository, but for other users the removal (thus icaclient breakage) might
> come at a very inconvenient time. One example is my wife: for her as a
> medical doctor icaclient is crucial during night and weekend shifts. At
> those times, whenever a crisis occurs it's very important that icaclient
> does work.
> 
> So I hope this can be considered.

I understand your conundrum, but the code is extremely smelly and should go. Anyhow, plugins in browsers are a lost cause, all major browsers are deprecating or have already removed support for plugins, hence the general use case isn't applicable anymore.

I've looked at the icaclient ebuilds and nowhere does it state a dependency on nspluginwrapper in RDEPEND. If that is so, then it's a bug, but given that the package seems maintained, I doubt that. I recommend you copy the ebuild to a local repo.
Comment 11 Mark (voidzero) 2017-04-02 15:52:12 UTC
> I understand your conundrum, but the code is extremely smelly and should go.
> Anyhow, plugins in browsers are a lost cause, all major browsers are
> deprecating or have already removed support for plugins, hence the general
> use case isn't applicable anymore.

I see. Alright, fair point.

> I've looked at the icaclient ebuilds and nowhere does it state a dependency
> on nspluginwrapper in RDEPEND. If that is so, then it's a bug, but given
> that the package seems maintained, I doubt that. I recommend you copy the
> ebuild to a local repo.

I think the USE flag is 'nsplugin', in IUSE. Might I be mistaking then; is this something unrelated?
Comment 12 David Seifert gentoo-dev 2017-04-02 15:58:34 UTC
(In reply to Mark (voidzero) from comment #11)
> > I've looked at the icaclient ebuilds and nowhere does it state a dependency
> > on nspluginwrapper in RDEPEND. If that is so, then it's a bug, but given
> > that the package seems maintained, I doubt that. I recommend you copy the
> > ebuild to a local repo.
> 
> I think the USE flag is 'nsplugin', in IUSE. Might I be mistaking then; is
> this something unrelated?

Indeed the nsplugin USE flag references that in pkg_postinst. CC'ing PolyC as he's the maintainer of icaclient.

@PolyC: any input? The following code:

        if use amd64 && [[ -f ${old_plugin} ]] ; then
                local wrapper="/usr/bin/nspluginwrapper"
                if [[ -x ${wrapper} ]] ; then
                        einfo "Removing npica.so from wrapper."
                        ${wrapper} -r ${old_plugin}
                fi
        fi

Seems like it relies on nspluginwrapper implicitly.
Comment 13 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2017-04-02 17:47:43 UTC
icaclient no longer needs nspluginwrapper to work. Citrix people fortunately release 64bit versions of their plugin for quite a while already. 
The code cited by David merely tries to remove any references to nspluginwrapper in case it's still installed.
Once nspluginwrapper ebuild is gone, the cited code can also go from icaclient ebuilds.
Comment 14 Mark (voidzero) 2017-04-03 15:51:12 UTC
(In reply to Lars Wendler (Polynomial-C) from comment #13)
> icaclient no longer needs nspluginwrapper to work. Citrix people fortunately
> release 64bit versions of their plugin for quite a while already. 
> The code cited by David merely tries to remove any references to
> nspluginwrapper in case it's still installed.
> Once nspluginwrapper ebuild is gone, the cited code can also go from
> icaclient ebuilds.

So, no problems there. That's great to hear. Thanks, folks!
Comment 15 David Seifert gentoo-dev 2017-04-17 07:53:25 UTC
commit 5f7b51de489ef7a1be9d886ee4ff61ea4c329613
Author: David Seifert <soap@gentoo.org>
Date:   Mon Apr 17 09:48:46 2017 +0200

    www-plugins/nspluginwrapper: Remove from tree