Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 608876 - app-text/podofo use cppunit even without test
Summary: app-text/podofo use cppunit even without test
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Zac Medico
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-10 15:59 UTC by Anielkis
Modified: 2017-06-10 19:45 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
new ebuild (podofo-0.9.5.ebuild,4.05 KB, text/plain)
2017-02-10 15:59 UTC, Anielkis 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anielkis 2017-02-10 15:59:53 UTC 
Created attachment 463152 [details]
new ebuild

When updating app-text/podofo to version 0.9.5 it failed to compile because of cppunit's functions

in temp/build.log was this message:

Set the BOOST_ROOT env var if you have problems.
-- Found Boost: /usr/include
Building shared PoDoFo library
Pkg-config found, creating a pkg-config file for linking against shared library.
-- Configuring done
-- Generating done
CMake Warning:
  Manually-specified variables were not used by the project:

    HAVE_CPPUNIT

-- Build files have been written to: /var/tmp/portage/app-text/podofo-0.9.5/work/podofo-0.9.5_build
>>> Source configured.


looking for changes in the source code I found that it was changed to PODOFO_BUILD_LIB_ONLY

It build changing the line:

-DHAVE_CPPUNIT=$(usex test ON OFF)

for:

-DPODOFO_BUILD_LIB_ONLY=$(usex test 0 1)


in the ebuild
Comment 1 Zac Medico gentoo-dev 2017-02-11 19:55:05 UTC 
(In reply to Anielkis from comment #0)
> Created attachment 463152 [details]
> new ebuild

When proposing ebuild changes, please attach a unified diff (created by 'diff -u oldfile newfile > newfile.diff').

> looking for changes in the source code I found that it was changed to
> PODOFO_BUILD_LIB_ONLY
> 
> It build changing the line:
> 
> -DHAVE_CPPUNIT=$(usex test ON OFF)
> 
> for:
> 
> -DPODOFO_BUILD_LIB_ONLY=$(usex test 0 1)
> 
> 
> in the ebuild

With your change, it only installs the library, and these files are no longer installed:

/usr/bin/podofobox
/usr/bin/podofocolor
/usr/bin/podofocountpages
/usr/bin/podofocrop
/usr/bin/podofoencrypt
/usr/bin/podofogc
/usr/bin/podofoimg2pdf
/usr/bin/podofoimgextract
/usr/bin/podofoimpose
/usr/bin/podofoincrementalupdates
/usr/bin/podofomerge
/usr/bin/podofopages
/usr/bin/podofopdfinfo
/usr/bin/podofosign
/usr/bin/podofotxt2pdf
/usr/bin/podofotxtextract
/usr/bin/podofouncompress
/usr/bin/podofoxmp
/usr/share/man/man1/podofobox.1
/usr/share/man/man1/podofocolor.1
/usr/share/man/man1/podofocountpages.1
/usr/share/man/man1/podofocrop.1
/usr/share/man/man1/podofoencrypt.1
/usr/share/man/man1/podofogc.1
/usr/share/man/man1/podofoimg2pdf.1
/usr/share/man/man1/podofoimgextract.1
/usr/share/man/man1/podofoimpose.1
/usr/share/man/man1/podofoincrementalupdates.1
/usr/share/man/man1/podofomerge.1
/usr/share/man/man1/podofopages.1
/usr/share/man/man1/podofopdfinfo.1
/usr/share/man/man1/podofotxt2pdf.1
/usr/share/man/man1/podofotxtextract.1
/usr/share/man/man1/podofouncompress.1
/usr/share/man/man1/podofoxmp.1
Comment 3 Zac Medico gentoo-dev 2017-06-10 19:45:42 UTC 
I've updated the ebuild to disable linking with cppunit whenever tests are not enabled:

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=24598d33ad2f2c5f9c2077ad850fb7516f782bdd