Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 608872 - dev-java/swt-3.8.2-r1 prepare fails on swt-3.8.2-libwebkit-compat.patch
Summary: dev-java/swt-3.8.2-r1 prepare fails on swt-3.8.2-libwebkit-compat.patch
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Java team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-10 14:58 UTC by Tom Dexter
Modified: 2018-02-28 21:30 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tom Dexter 2017-02-10 14:58:32 UTC 
dev-java/swt-3.8.2-r1 fails on the prepare step applying swt-3.8.2-libwebkit-compat.patch.

I was able to trace this to the fact that the patch has these lines:

	long /*int*/ session = WebKitGTK.webkit_get_default_session ();
	long /*int*/ originalAuth = WebKitGTK.soup_session_get_feature (session, WebKitGTK.webkit_soup_auth_dialog_get_type ());

...whereas the file being patched (src/org/eclipse/swt/browser/WebKit.java) has:

	int /*long*/ session = WebKitGTK.webkit_get_default_session ();
	int /*long*/ originalAuth = WebKitGTK.soup_session_get_feature (session, WebKitGTK.webkit_soup_auth_dialog_get_type ());

...at line 598. That is "long /*int*/" vs "int /*long*/".
Comment 1 Gautama 2017-02-12 08:29:35 UTC 
I manually applied the change, and after that the emerge ran fine.
Comment 2 Tom Dexter 2018-02-28 19:32:02 UTC 
This appears to be fixed as of swt-3.7.2-r2.
Comment 3 James Le Cuirot gentoo-dev 2018-02-28 21:30:45 UTC 
We no longer enable webkit so this isn't an issue now.