Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 608300 - kde-plasma/kscreenlocker-5.9.0 bad dependency on x11-libs/libXcursor
Summary: kde-plasma/kscreenlocker-5.9.0 bad dependency on x11-libs/libXcursor
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo KDE team
URL: https://bugs.kde.org/show_bug.cgi?id=...
Whiteboard: tracking upstream
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-05 11:05 UTC by Ostashevskyi Viktor
Modified: 2017-02-11 03:48 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ostashevskyi Viktor 2017-02-05 11:05:50 UTC 
Ebuild doesn't have dependency on x11-libs/libXcursor, and grepping in sources doesn't show any usage except one line in main CMakeLists.txt:

target_link_libraries(KScreenLocker                                                                                                   
PUBLIC                                                                                                                                
   Qt5::Core                                                                                                                          
   Qt5::X11Extras                                                                                                                     
PRIVATE                                                                                                                               
   KF5::I18n                                                                                                                          
   KF5::IdleTime                                                                                                                      
   KF5::GlobalAccel                                                                                                                   
   KF5::Notifications                                                                                                                 
   KF5::CoreAddons                                                                                                                    
   KF5::ConfigGui                                                                                                                     
   KF5::WindowSystem                                                                                                                  
   ${X11_LIBRARIES}                                                                                                                   
   ${X11_Xcursor_LIB}                                                                                                                 
   XCB::XCB                                                                                                                           
   XCB::KEYSYMS                                                                                                                       
   KF5::WaylandServer                                                                                                                 
   Wayland::Server                                                                                                                    
)

I have a strong feeling it is not needed in CMakeLists.txt
Comment 1 Andreas Sturmlechner gentoo-dev 2017-02-05 12:12:45 UTC 
So, what happens when you build kscreenlocker with X11_Xcursor_LIB removed?
Comment 2 Ostashevskyi Viktor 2017-02-05 12:18:50 UTC 
(In reply to Andreas Sturmlechner from comment #1)
> So, what happens when you build kscreenlocker with X11_Xcursor_LIB removed?

Compiles cleanly.
Comment 3 Andreas Sturmlechner gentoo-dev 2017-02-05 14:55:54 UTC 
Would you like to report this upstream? Afaik this has no effect on our build, libXfixes present or not.
Comment 4 Andreas Sturmlechner gentoo-dev 2017-02-05 14:56:14 UTC 
Would you like to report this upstream? Afaik this has no effect on our build, libXcursor present or not.
Comment 5 Ostashevskyi Viktor 2017-02-05 17:05:42 UTC 
Reported upstream: https://bugs.kde.org/show_bug.cgi?id=376068
Comment 6 Johannes Huber (RETIRED) gentoo-dev 2017-02-07 17:37:26 UTC 
(In reply to Ostashevskyi Viktor from comment #5)
> Reported upstream: https://bugs.kde.org/show_bug.cgi?id=376068

Thanks.
Comment 7 Andreas Sturmlechner gentoo-dev 2017-02-10 12:02:53 UTC 
Fixed upstream: https://cgit.kde.org/kscreenlocker.git/commit/?id=dd9a089cfaefb24f012a137618e00005a48b6009

Thanks!
Comment 8 Ostashevskyi Viktor 2017-02-10 14:31:40 UTC 
That is great, but when it will be fixed in Gentoo? In 5.9.2 or in 5.10?
Comment 9 Michael Palimaka (kensington) gentoo-dev 2017-02-11 03:48:40 UTC 
It turns out this was causing a build failure with libXcursor missing, so I've backported to 5.9.1.

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d2ced4da6a47084e23ed66581e056c2755f38f9c
https://gitweb.gentoo.org/proj/kde.git/commit/?id=458ce36bdc512865c90a5aa170c8986134bbd540