Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 60813 - patch that adds internalBorder: <width> / -ib <width> to aterm
Summary: patch that adds internalBorder: <width> / -ib <width> to aterm
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Michal Januszewski (RETIRED)
URL: https://sourceforge.net/tracker/index...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-08-18 12:38 UTC by Mathias Gumz
Modified: 2004-08-23 05:19 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
patch to add -ib <width> / internalBorder: <width> (aterm-internal-border.4.2.2.patch,3.14 KB, patch)
2004-08-18 12:39 UTC, Mathias Gumz
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mathias Gumz 2004-08-18 12:38:58 UTC
the attached patch adds either:
  internalBorder: <width>
or 
  -ib <width>
to aterm. thats the the border from the internal frame to where windowdecorations would start.


Reproducible: Always
Steps to Reproduce:
1.
2.
3.
Comment 1 Mathias Gumz 2004-08-18 12:39:35 UTC
Created attachment 37684 [details, diff]
patch to add -ib <width> / internalBorder: <width>
Comment 2 Michal Januszewski (RETIRED) gentoo-dev 2004-08-21 17:41:14 UTC
This patch doesn't work. Aterm segfaults immediately after starting when it's applied. I've checked it with all the Gentoo patches and without any of them - the results were the same.
Comment 3 Mathias Gumz 2004-08-22 12:19:46 UTC
i checked it again: a plain aterm + configure + make -> no crash here. i know some guys on the irc who used the patch and it worked immeadiatly. so, perhaps you can provide a bt from gdb? just "doesnt work" isnt enough to nail the problem down :)
Comment 4 Michal Januszewski (RETIRED) gentoo-dev 2004-08-22 18:39:50 UTC
Here is some more info:
(vanilla aterm + your patch)
CFLAGS=-g
Configured with: ./configure --enable-transparency --enable-fading --enable-background-image --enable-menubar --enable-graphics --enable-utmp --with-x (it's the same with just './configure').

Debugging session:

(gdb) r
Starting program: /tmp/aterm-0.4.2/src/aterm 
Detaching after fork from child process 29107.

Program received signal SIGSEGV, Segmentation fault.
0x0805916d in rmemset (p=0x807dbb7, c=0 '\0', len=-210064) at rmemset.c:82
82              *lp++ = c;
(gdb) bt
#0  0x0805916d in rmemset (p=0x807dbb7, c=0 '\0', len=-210064) at rmemset.c:82
#1  0x0805d87d in scr_expose (x=0, y=34, width=53, height=306) at screen.c:1818
#2  0x0804d59b in process_x_event (ev=0xbffff4b0) at command.c:2414
#3  0x0804cd1e in cmd_getc () at command.c:1981
#4  0x0804f81e in main_loop () at command.c:3459
#5  0x080541a6 in main (argc=1, argv=0xbffff6f4) at main.c:1961
(gdb) frame 1
#1  0x0805d87d in scr_expose (x=0, y=34, width=53, height=306) at screen.c:1818
1818                MEMSET(&(drawn_text[i][part_beg.col]), 0,
(gdb) l 1810
1805        MIN_IT(part_beg.col, TermWin.bcol - 1);
1806        MIN_IT(full_beg.col, TermWin.bcol - 1);
1807        MIN_IT(part_end.col, TermWin.bcol - 1);
1808        MIN_IT(full_end.col, TermWin.bcol - 1);
1809        MIN_IT(part_beg.row, TermWin.nrow - 1);
1810        MIN_IT(full_beg.row, TermWin.nrow - 1);
1811        MIN_IT(part_end.row, TermWin.nrow - 1);
1812        MIN_IT(full_end.row, TermWin.nrow - 1);
1813    
1814        D_SCREEN((stderr, "scr_expose(x:%d, y:%d, w:%d, h:%d) area (c:%d,r:%d)-(c:%d,r:%d)", x, y, width, height, part_beg.col, part_beg.row, part_end.col, part_end.row));
(gdb) p part_beg
$1 = {row = 2, col = 79}
(gdb) p part_end
$2 = {row = 23, col = 8}
(gdb) p full_beg
$3 = {row = 3, col = 0}
(gdb) p full_end
$4 = {row = 23, col = 7}
Comment 5 Michal Januszewski (RETIRED) gentoo-dev 2004-08-23 05:19:31 UTC
Fixed patch added to aterm-0.4.2-r11.