Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 607710 - flag-o-matic: can -fstack-check be part of ALLOWED_FLAGS?
Summary: flag-o-matic: can -fstack-check be part of ALLOWED_FLAGS?
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Toolchain Maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-01-30 11:14 UTC by Agostino Sarubbo
Modified: 2017-02-09 16:28 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2017-01-30 11:14:38 UTC 
I saw this situation from the firefox build:

* strip-flags: CFLAGS: changed '-march=x86-64 -msse4.2 -fno-strict-overflow -fstack-protector-all -fstack-check=specific' to '-march=x86-64 -fno-strict-overflow -fstack-protector-all'

it deleted -fstack-check=specific

-fstack-check=specific comes from the current hardened gcc setup we have:


# gcc -E -v - </dev/null 2>&1 | sed -n 's/.* -v - //p'
-fno-strict-overflow -mtune=generic -march=x86-64 -fPIE -fstack-protector-all -fstack-check=specific

So while I want to replicate an hardened build of some package via package.env, strip-flags deleted something.

Do you think is fine/safe have it in ALLOWED_FLAGS?