Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 605676 - media-tv/kodi-17.0_rc* : cmake project still use autoreconf during compile time
Summary: media-tv/kodi-17.0_rc* : cmake project still use autoreconf during compile time
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Gentoo Linux bug wranglers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-01-14 11:40 UTC by Marc Perrudin
Modified: 2017-01-19 14:59 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
autotools.patch (autotools.patch,1.28 KB, patch)
2017-01-14 11:40 UTC, Marc Perrudin
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Marc Perrudin 2017-01-14 11:40:00 UTC
Created attachment 460000 [details, diff]
autotools.patch

With the switch to cmake build system, the eautoreconf part was dropped. But some part of what kodi call externalproject still use autoreconf (cpluff, texturepacker...) during compile time.

I attach a patch for externalproject with included sources.
Comment 1 Craig Andrews gentoo-dev 2017-01-16 17:17:28 UTC
What problem does this proposed change solve?
Comment 2 Marc Perrudin 2017-01-16 18:12:56 UTC
I don't have a deep knowledge in portage but the direct use of autoreconf instead of eautoreconf seem to be discouraged (forbidden ?). 

This was done in the ebuild until rc, if it's ok to use autoreconf, fell free to close this bug.

Marc.
Comment 3 Craig Andrews gentoo-dev 2017-01-16 22:25:34 UTC
Thanks for that info, it makes to me.

I've included your patch in https://github.com/gentoo/gentoo/pull/3513

Thank you for this bug report and the patch fixing the issue!