Bug 605578 – media-tv/kodi-9999: missing dev-libs/libcdio dependency

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description hal 2017-01-13 14:26:52 UTC]

Created attachment 459876 [details, diff]
libcdio patch

Current master fails to build due to a missing dependency `dev-libs/libcdio`.

Patch attached.

[Comment 1 Craig Andrews 2017-01-13 22:16:13 UTC]

Reported upstream:
https://github.com/xbmc/xbmc/pull/11442

Also included in https://github.com/gentoo/gentoo/pull/3448

Next time, please include the build log.

[Comment 2 Marc Perrudin 2017-01-14 11:13:58 UTC]

Dependency exist for dvd use flag but the dependency doesn't require -minimal when the dvd use flag is not set.

[Comment 3 Craig Andrews 2017-01-16 22:24:24 UTC]

included in https://github.com/gentoo/gentoo/pull/3513

Thank you for this bug report and the patch fixing the issue!

[Comment 4 Steffen Hau 2017-01-20 10:22:29 UTC]

You're now depending on dev-libs/libcdio twice (directly and with use dvd). You can omit the dvd dep.

[Comment 5 Craig Andrews 2017-01-21 02:08:46 UTC]

(In reply to Steffen Hau from comment #4)
> You're now depending on dev-libs/libcdio twice (directly and with use dvd).
> You can omit the dvd dep.

The dvd dependency is is on libcdio[-minimal] - the use flag is significant. Therefore that dependency can't be omitted.

[Comment 6 Steffen Hau 2017-01-23 11:35:52 UTC]

(In reply to candrews from comment #5)
> (In reply to Steffen Hau from comment #4)
> > You're now depending on dev-libs/libcdio twice (directly and with use dvd).
> > You can omit the dvd dep.
> 
> The dvd dependency is is on libcdio[-minimal] - the use flag is significant.
> Therefore that dependency can't be omitted.

If you remeber PR3027, the dvd flag was added to address ENABLE_OPTICAL. dev-libs/libcdio[-minimal] came from previous ebuilds. I can't see anything in Kodi requiring the tools from libcdio. If you take a look at tools/depends/target/libcdio/Makefile you can see that the Kodi devs are building libcdio with --with-cd-drive=no --with-cd-info=no --with-cd-paranoia=no --with-cdda-player=no --with-cd-read=no --with-iso-info=no --with-iso-read=no, so basically all tools are disabled. So a dependency on dev-libs/libcdio is entirely sufficient and the use flag, as it only enables ENABLE_OPTICAL which itself does only require libcdio which itself is now a hard dependency, can surely be omitted!

[Comment 7 Steffen Hau 2017-01-26 11:07:48 UTC]

Any reason you're ignoring my comment?

[Comment 8 Craig Andrews 2017-01-28 22:47:03 UTC]

(In reply to Steffen Hau from comment #6)
> (In reply to candrews from comment #5)
> > (In reply to Steffen Hau from comment #4)
> > > You're now depending on dev-libs/libcdio twice (directly and with use dvd).
> > > You can omit the dvd dep.
> > 
> > The dvd dependency is is on libcdio[-minimal] - the use flag is significant.
> > Therefore that dependency can't be omitted.
> 
> If you remeber PR3027, the dvd flag was added to address ENABLE_OPTICAL.
> dev-libs/libcdio[-minimal] came from previous ebuilds. I can't see anything
> in Kodi requiring the tools from libcdio. If you take a look at
> tools/depends/target/libcdio/Makefile you can see that the Kodi devs are
> building libcdio with --with-cd-drive=no --with-cd-info=no
> --with-cd-paranoia=no --with-cdda-player=no --with-cd-read=no
> --with-iso-info=no --with-iso-read=no, so basically all tools are disabled.
> So a dependency on dev-libs/libcdio is entirely sufficient and the use flag,
> as it only enables ENABLE_OPTICAL which itself does only require libcdio
> which itself is now a hard dependency, can surely be omitted!

Thanks for all this information. I also double checked and it works fine with dev-libs/libcdio[minimal].

(In reply to Steffen Hau from comment #7)
> Any reason you're ignoring my comment?

I'm not. :)

Included in https://github.com/gentoo/gentoo/pull/3699