Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 605316 - app-office/texstudio-2.12 version bump
Summary: app-office/texstudio-2.12 version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Manuel Rüger (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 597574
  Show dependency tree
 
Reported: 2017-01-10 22:25 UTC by Jonas Stein
Modified: 2017-01-22 23:14 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
ebuild that works on my system (texstudio-2.12.0.ebuild,2.07 KB, text/plain)
2017-01-18 18:21 UTC, James R.
Details
ebuild with the minor changes (texstudio-2.12.0.ebuild,1.93 KB, text/plain)
2017-01-18 22:22 UTC, James R.
Details
ebuild with proper icon bit (texstudio-2.12.0.ebuild,1.95 KB, text/plain)
2017-01-19 23:42 UTC, James R.
Details
texstudio-2.12.0.diff (texstudio-2.12.0.diff,595 bytes, text/plain)
2017-01-22 17:08 UTC, Jonas Stein
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jonas Stein gentoo-dev 2017-01-10 22:25:01 UTC
http://texstudio.sourceforge.net/manual/current/CHANGELOG.txt

Many bugs are fixed:
- fix: hg version comparision assumed 'larger' if the version could not be determined https://bugs.gentoo.org/show_bug.cgi?id=597574
Comment 1 James R. 2017-01-18 18:21:04 UTC
Created attachment 460568 [details]
ebuild that works on my system

This attachment is the ebuild that works on my system.  The only change from the previous one in the tree is that the new distfile had all the source files in a nested folder, so moving them all out allowed everything to work again.
Comment 2 Jonas Stein gentoo-dev 2017-01-18 20:09:33 UTC
Thank you very much. 
We could use a variable in
mv ./texstudio2.12.0/* ./

and remove the three # comment lines in the middle.

A for loop like

for i in 16x16 22x22 32x32 48x48 64x64 128x128; do
	insinto /usr/share/icons/hicolor/${i}/apps
	newins utilities/${PN}${i}.png ${PN}.png
done

is often used, but as far I know it is superseded by 
doicon
https://devmanual.gentoo.org/eclass-reference/eutils.eclass/
Comment 3 James R. 2017-01-18 22:22:34 UTC
Created attachment 460574 [details]
ebuild with the minor changes

Here is a file with the minor changes made.  It still successfully installs on my system
Comment 4 James R. 2017-01-19 23:42:30 UTC
Created attachment 460674 [details]
ebuild with proper icon bit

Alright, I swear this is my last attempt at it.  Noticed that the icons were missing, so found the right command to install them.
Comment 5 Jonas Stein gentoo-dev 2017-01-21 20:28:13 UTC
James, thank you very much. That was helpful.

There is a "ebuild-checker" which can show several common mistakes in ebuilds.
You start it with repoman -d full 

We still have things to fix. 
I added your ebuild in my repository [1] to the branch "texstudio" and fixed some lines repoman had claims about. Everybody is invited to test and improve the ebuild too so that we can get it in the tree soon. 

[1] https://github.com/jonasstein/jstein-overlay/blob/texstudio/app-office/texstudio/texstudio-2.12.0.ebuild
Comment 6 Manuel Rüger (RETIRED) gentoo-dev 2017-01-22 02:06:54 UTC
Thanks. I'll take a look at your changes this weekend. Please apply a unified diff next time, that makes it easier to see what changed.
Comment 7 Jonas Stein gentoo-dev 2017-01-22 14:40:01 UTC
I merged all changes to one PR:
https://github.com/gentoo/gentoo/pull/3586

It compiles fine here (just one QA upstream warning, which is already reported).

I changed the Path $S, so we do not need do use the mv workaround.
James fixed the icons.
Comment 8 Manuel Rüger (RETIRED) gentoo-dev 2017-01-22 14:56:02 UTC
(In reply to Jonas Stein from comment #7)
> I merged all changes to one PR:
> https://github.com/gentoo/gentoo/pull/3586
> 
> It compiles fine here (just one QA upstream warning, which is already
> reported).
> 
> I changed the Path $S, so we do not need do use the mv workaround.
> James fixed the icons.

Please attach a unified diff to this bug.
Comment 9 Jonas Stein gentoo-dev 2017-01-22 17:08:22 UTC
Created attachment 460966 [details]
texstudio-2.12.0.diff

diff texstudio-2.11.2-r1.ebuild texstudio-2.12.0.ebuild > texstudio-2.12.0.diff
Comment 10 Manuel Rüger (RETIRED) gentoo-dev 2017-01-22 23:14:28 UTC
commit 944806cc7884623945008c05fe37be8fff110b9d
Author: Manuel Rüger <mrueg@gentoo.org>
Date:   Mon Jan 23 00:12:31 2017 +0100

    app-office/texstudio: Version bump to 2.12.0
    
    Gentoo-Bug: #605316
    
    Thanks to James R. and Jonas Stein
    
    Package-Manager: portage-2.3.3