Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 60530 - Bugs fix in Gentoo's Zsh completion
Summary: Bugs fix in Gentoo's Zsh completion
Status: RESOLVED REMIND
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Mamoru KOMACHI (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-08-16 01:33 UTC by Bapt
Modified: 2004-08-17 23:56 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
patch for _portage (_portage-20040816.patch,658 bytes, patch)
2004-08-16 01:34 UTC, Bapt
Details | Diff
patch for _gentoolkit (_gentoolkit-20040816.patch,1.28 KB, patch)
2004-08-16 01:35 UTC, Bapt
Details | Diff
patch for _gcc-config (_gcc-config-20040816.patch,733 bytes, patch)
2004-08-16 01:35 UTC, Bapt
Details | Diff
gcc-config patch atop baptux's patched gcc-config (_gcc-config-0817.patch,514 bytes, patch)
2004-08-17 20:32 UTC, oberyno
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Bapt 2004-08-16 01:33:49 UTC
_gcc-config:
    remove dependencies to sed (pure zsh code now ;))
    Change '(- :)'':profiles:_gcc_profile' to '(- :):profiles:_gcc_profile'
    to make it work (at least for me ;)).
    added local definition for profile
_portage:
    add local definition to some vars
_gentoolkit:
    add local definition for some vars
    remove dependencies to sed/grep (pure zsh code now ;)) (quite longer, can 
    be optimize ;))
    Change '(- :)'':' to '(- :):overlays:_overlays' to '(- 
    :):overlays:_overlays'
    to make it work (at least for me ;)).

I don't like the way the completion for qpkg is done, I'll have a look at it as soon as I'll have time.

I also remove all "ugly" sed, cat, since zsh can do the stuff himself.

Reproducible: Always
Steps to Reproduce:
1. patch the function
2. try again ;)
3.
Comment 1 Bapt 2004-08-16 01:34:41 UTC
Created attachment 37515 [details, diff]
patch for _portage
Comment 2 Bapt 2004-08-16 01:35:20 UTC
Created attachment 37516 [details, diff]
patch for _gentoolkit
Comment 3 Bapt 2004-08-16 01:35:42 UTC
Created attachment 37517 [details, diff]
patch for _gcc-config
Comment 4 Mamoru KOMACHI (RETIRED) gentoo-dev 2004-08-17 14:41:17 UTC
Applied these patches. Thanks. When you finish prettifying qpkg please let me know.
Comment 5 oberyno 2004-08-17 20:32:09 UTC
Created attachment 37637 [details, diff]
gcc-config patch atop baptux's patched gcc-config

Thanks for the fixes baptux. 
_gcc-config:
   Your patch only lists the last profile for me. 
_gentoolkit: qpkg and equery
  It's slow because of this part:
    #Reading informations from Portage
    portdir="$(portageq portdir)"
    #pkgdir="$(portageq pkgdir)"
    portdir_overlay="$(portageq portdir_overlay)"
  If that section is reverted, it will be fast again.
  If there are any other problems with it, I'll be willing to fix them.
Comment 6 Bapt 2004-08-17 23:56:08 UTC
I'll pretify qpkg when I'll have time, and then open a new bug ;) 
(the goal is to make it able to at least do qpkg -q -I <something>, it can't do it know).
For the rest, the fact is only that I hate seeing grep/cat/.../other stuff like that in zsh scripts,  moreover in completion function. Completion should be pure zsh (I think)