Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 604572 - dev-php/pecl-redis-3.1.0 version bump with corrected DEPEND's, USE_PHP="php7-0 php7-1" and EAPI=6 support
Summary: dev-php/pecl-redis-3.1.0 version bump with corrected DEPEND's, USE_PHP="php7-...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: PHP Bugs
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-01-03 21:41 UTC by Steffen 'j0inty' Stollfuß
Modified: 2017-01-17 14:39 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
pecl-redis-3.1.0.ebuild with USE_PHP="php7-0 php7-1", EAPI=6 support and fixed DEPEND for igbinary serialization (pecl-redis-3.1.0.ebuild,1.20 KB, text/plain)
2017-01-03 21:41 UTC, Steffen 'j0inty' Stollfuß
Details
pecl-redis-3.1.0.ebuildadded missing CREDITS and COPYING in DOCS and tried to get rid of the src_test (pecl-redis-3.1.0.ebuild,1.90 KB, text/plain)
2017-01-04 00:13 UTC, Steffen 'j0inty' Stollfuß
Details
metadata.xml with description for both USE="igbinary redis-session" flags (metadata.xml,629 bytes, text/xml)
2017-01-04 00:15 UTC, Steffen 'j0inty' Stollfuß
Details
pecl-redis-3.1.1_rc1.ebuild Caution: UseItOwnRisk: ebuild use an assignment which should not be done in an ebuild (pecl-redis-3.1.1_rc1.ebuild,2.34 KB, text/plain)
2017-01-04 11:19 UTC, Steffen 'j0inty' Stollfuß
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Steffen 'j0inty' Stollfuß 2017-01-03 21:41:15 UTC
Created attachment 458610 [details]
pecl-redis-3.1.0.ebuild with USE_PHP="php7-0 php7-1", EAPI=6 support and fixed DEPEND for igbinary serialization

Hi,

I wrote this ebuild to fix problems with the currently available ebuild in portage tree:

* added support for USE_PHP="php7-0 php7-1"
* corrected the DEPEND for dev-php/igbinary package
* moved to EAPI=6

regards
j0inty
Comment 1 Steffen 'j0inty' Stollfuß 2017-01-04 00:13:57 UTC
Created attachment 458620 [details]
pecl-redis-3.1.0.ebuildadded missing CREDITS and COPYING in DOCS and tried to get rid of the src_test
Comment 2 Steffen 'j0inty' Stollfuß 2017-01-04 00:15:45 UTC
Created attachment 458622 [details]
metadata.xml with description for both USE="igbinary redis-session" flags
Comment 3 Brian Evans (RETIRED) gentoo-dev 2017-01-04 01:57:39 UTC
Oh wonderful.  This is now a small mess since they combined the two branches together.

I am going to skip 3.1.0 as there are issues in the integration as seen on the github source page, but 3.1.1 should be soon released to fix it.
Comment 4 Brian Evans (RETIRED) gentoo-dev 2017-01-04 01:58:54 UTC
(In reply to Steffen 'j0inty' Stollfuß from comment #1)
> Created attachment 458620 [details]
> pecl-redis-3.1.0.ebuildadded missing CREDITS and COPYING in DOCS and tried
> to get rid of the src_test

We never install the COPYING or any other license file in Gentoo
Comment 5 Michael Orlitzky gentoo-dev 2017-01-04 02:21:15 UTC
I totally added this last night.

Once I removed the versions with the 5.6 <-> 7.x hack, the dependencies became simple again. I didn't notice the new --enable-redis-session option though. Maybe we should wait and do that in 3.1.1 if it's "coming soon" and fixes other things, though.
Comment 6 Steffen 'j0inty' Stollfuß 2017-01-04 11:14:57 UTC
(In reply to Brian Evans from comment #3)
> Oh wonderful.  This is now a small mess since they combined the two branches
> together.
> 
> I am going to skip 3.1.0 as there are issues in the integration as seen on
> the github source page, but 3.1.1 should be soon released to fix it.

Hi Brian,

to test the current release candidate I'm using another ebuild for this.

This ebuild does everything as expected, but todo this I was forced to use a assignment which should not be done in an ebuild file.

But have a look by your own.

regards
j0inty
Comment 7 Steffen 'j0inty' Stollfuß 2017-01-04 11:19:08 UTC
Created attachment 458704 [details]
pecl-redis-3.1.1_rc1.ebuild Caution: UseItOwnRisk: ebuild use an assignment which should not be done in an ebuild
Comment 8 Brian Evans (RETIRED) gentoo-dev 2017-01-04 16:02:07 UTC
(In reply to Steffen 'j0inty' Stollfuß from comment #7)
> Created attachment 458704 [details]
> pecl-redis-3.1.1_rc1.ebuild Caution: UseItOwnRisk: ebuild use an assignment
> which should not be done in an ebuild

> PV="${PV//_rc1/_RC1}"
> MY_PV="${PV//_/}"

should be just MY_PV="${PV//_rc1/RC1}" for this particular ebuild... never ever try to change PV
Comment 9 Steffen 'j0inty' Stollfuß 2017-01-04 16:25:58 UTC
(In reply to Brian Evans from comment #8)
> (In reply to Steffen 'j0inty' Stollfuß from comment #7)
> > Created attachment 458704 [details]
> > pecl-redis-3.1.1_rc1.ebuild Caution: UseItOwnRisk: ebuild use an assignment
> > which should not be done in an ebuild
> 
> > PV="${PV//_rc1/_RC1}"
> > MY_PV="${PV//_/}"
> 
> should be just MY_PV="${PV//_rc1/RC1}" for this particular ebuild... never
> ever try to change PV

Hi,

that was the reason I added the warning, too. But your fix alone doesn't work for my ebuild. I know about the MY_VAR's and the original ${P}, ${PV}, ...

My notice above the PV statement pointed you out why I'm at time was only to get the php-ext-source src_unpack working which called by php-ext-pecl-r3 The Step: copy working dir to the php_target dirs.

# php-ext-pecl-r3 set ${S} as 
# S="${WORKDIR}/${PHP_EXT_PECL_PKG}-${PV/_/}"
# this results in phpredis-3.1.1rc1
# but we need phpredis-3.1.1RC1 when in php-ext-source-r3.eclass
# the source copied for the diffrent php targets
PV="${PV//_rc1/_RC1}"

MY_PV="${PV//_/}"

regards
Comment 10 Brian Evans (RETIRED) gentoo-dev 2017-01-04 16:37:21 UTC
(In reply to Steffen 'j0inty' Stollfuß from comment #9)
> (In reply to Brian Evans from comment #8)
> > (In reply to Steffen 'j0inty' Stollfuß from comment #7)
> > > Created attachment 458704 [details]
> > > pecl-redis-3.1.1_rc1.ebuild Caution: UseItOwnRisk: ebuild use an assignment
> > > which should not be done in an ebuild
> > 
> > > PV="${PV//_rc1/_RC1}"
> > > MY_PV="${PV//_/}"
> > 
> > should be just MY_PV="${PV//_rc1/RC1}" for this particular ebuild... never
> > ever try to change PV
> 
> Hi,
> 
> that was the reason I added the warning, too. But your fix alone doesn't
> work for my ebuild. I know about the MY_VAR's and the original ${P}, ${PV},
> ...
> 
> My notice above the PV statement pointed you out why I'm at time was only to
> get the php-ext-source src_unpack working which called by php-ext-pecl-r3
> The Step: copy working dir to the php_target dirs.
> 
> # php-ext-pecl-r3 set ${S} as 
> # S="${WORKDIR}/${PHP_EXT_PECL_PKG}-${PV/_/}"
> # this results in phpredis-3.1.1rc1
> # but we need phpredis-3.1.1RC1 when in php-ext-source-r3.eclass
> # the source copied for the diffrent php targets
> PV="${PV//_rc1/_RC1}"
> 
> MY_PV="${PV//_/}"
> 
> regards

So reset S after the inherit
Comment 11 Steffen 'j0inty' Stollfuß 2017-01-04 16:45:21 UTC
(In reply to Brian Evans from comment #10)
> (In reply to Steffen 'j0inty' Stollfuß from comment #9)
> > (In reply to Brian Evans from comment #8)
> > > (In reply to Steffen 'j0inty' Stollfuß from comment #7)
> > > > Created attachment 458704 [details]
> > > > pecl-redis-3.1.1_rc1.ebuild Caution: UseItOwnRisk: ebuild use an assignment
> > > > which should not be done in an ebuild
> > > 
> > > > PV="${PV//_rc1/_RC1}"
> > > > MY_PV="${PV//_/}"
> > > 
> > > should be just MY_PV="${PV//_rc1/RC1}" for this particular ebuild... never
> > > ever try to change PV
> > 
> > Hi,
> > 
> > that was the reason I added the warning, too. But your fix alone doesn't
> > work for my ebuild. I know about the MY_VAR's and the original ${P}, ${PV},
> > ...
> > 
> > My notice above the PV statement pointed you out why I'm at time was only to
> > get the php-ext-source src_unpack working which called by php-ext-pecl-r3
> > The Step: copy working dir to the php_target dirs.
> > 
> > # php-ext-pecl-r3 set ${S} as 
> > # S="${WORKDIR}/${PHP_EXT_PECL_PKG}-${PV/_/}"
> > # this results in phpredis-3.1.1rc1
> > # but we need phpredis-3.1.1RC1 when in php-ext-source-r3.eclass
> > # the source copied for the diffrent php targets
> > PV="${PV//_rc1/_RC1}"
> > 
> > MY_PV="${PV//_/}"
> > 
> > regards
> 
> So reset S after the inherit

Ohje ...

Sometimes it can be so simple and you don't see it ... :D

Thanks

j0inty
Comment 12 Steffen 'j0inty' Stollfuß 2017-01-04 17:04:21 UTC
(In reply to Brian Evans from comment #10)
> (In reply to Steffen 'j0inty' Stollfuß from comment #9)
> > (In reply to Brian Evans from comment #8)
> > > (In reply to Steffen 'j0inty' Stollfuß from comment #7)
> > > > Created attachment 458704 [details]
> > > > pecl-redis-3.1.1_rc1.ebuild Caution: UseItOwnRisk: ebuild use an assignment
> > > > which should not be done in an ebuild
> > > 
> > > > PV="${PV//_rc1/_RC1}"
> > > > MY_PV="${PV//_/}"
> > > 
> > > should be just MY_PV="${PV//_rc1/RC1}" for this particular ebuild... never
> > > ever try to change PV
> > 
> > Hi,
> > 
> > that was the reason I added the warning, too. But your fix alone doesn't
> > work for my ebuild. I know about the MY_VAR's and the original ${P}, ${PV},
> > ...
> > 
> > My notice above the PV statement pointed you out why I'm at time was only to
> > get the php-ext-source src_unpack working which called by php-ext-pecl-r3
> > The Step: copy working dir to the php_target dirs.
> > 
> > # php-ext-pecl-r3 set ${S} as 
> > # S="${WORKDIR}/${PHP_EXT_PECL_PKG}-${PV/_/}"
> > # this results in phpredis-3.1.1rc1
> > # but we need phpredis-3.1.1RC1 when in php-ext-source-r3.eclass
> > # the source copied for the diffrent php targets
> > PV="${PV//_rc1/_RC1}"
> > 
> > MY_PV="${PV//_/}"
> > 
> > regards
> 
> So reset S after the inherit
Sry but I must revert last comment because the problem exists while the "inherit" is running.

build.log
https://gist.github.com/j0inty/82031d7eeeab81c78f972cfc25f307ce

The error occured in php-ext-source-r3_src_unpack as I said before when this function create the "source" folder for the diffrent php_targets (php5-6 php7-0 ...). A php_target source folder is nothing more that the ${S} copied to ${WORKDIR}/${php_target}.

Here the name of the extracted folder from archive is not the same as in ${S}.

regards
Comment 13 Brian Evans (RETIRED) gentoo-dev 2017-01-17 14:39:11 UTC
3.1.1_rc2 is now in the tree