Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 604250 - dev-util/vtable-dumper-1.1: major QA issues with the build
Summary: dev-util/vtable-dumper-1.1: major QA issues with the build
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Mike Gilbert
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-12-31 11:44 UTC by Michał Górny
Modified: 2016-12-31 16:07 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2016-12-31 11:44:09 UTC
>>> Compiling source in /tmp/portage/dev-util/vtable-dumper-1.1/work/vtable-dumper-1.1 ...
make -j12 
gcc dump-vtable.c -o vtable-dumper -ldl -lelf -lstdc++ -Wall

[...]

>>> Install vtable-dumper-1.1 into /tmp/portage/dev-util/vtable-dumper-1.1/image/ category dev-util
make -j12 prefix=/tmp/portage/dev-util/vtable-dumper-1.1/image/usr install 
gcc dump-vtable.c -o vtable-dumper -ldl -lelf -lstdc++ -Wall


So:

a. doesn't respect CC, CFLAGS, LDFLAGS, pretty much anything.

b. rebuilds the same thing twice.

c. links directly to -lstdc++ which eliminates any other C++ library.
Comment 1 Mike Gilbert gentoo-dev 2016-12-31 15:58:20 UTC
Issues a and b have been fixed upstream.

https://github.com/lvc/vtable-dumper/commit/2fb122e7004a6ff34224d3e7743fe96ef5dba26b

Issue c may be an non-issue; this is not a C++ program. Rather, it is a C program that calls a private symbol which is defined in libstdc++.

https://github.com/lvc/vtable-dumper/blob/master/dump-vtable.c#L196

If you think that is wrong, please complain upstream.

https://github.com/lvc/vtable-dumper/issues
Comment 2 Mike Gilbert gentoo-dev 2016-12-31 16:07:15 UTC
(In reply to Mike Gilbert from comment #1)
> Issues a and b have been fixed upstream.

Fixed in Gentoo with a version bump.

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3fabe787da21d5719d93d842020e7b0db9586beb