Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 604094 - media-tv/xmltv-0.5.68 fails to configure correctly if un-needed deps are not installed
Summary: media-tv/xmltv-0.5.68 fails to configure correctly if un-needed deps are not ...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Proxy Maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-12-29 22:38 UTC by Andrew Fowler
Modified: 2018-02-03 00:00 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch to Makefile.PL (Makefile.PL.patch,19.50 KB, patch)
2016-12-29 22:38 UTC, Andrew Fowler
Details | Diff
Draft ebuild which uses patch (xmltv-0.5.68-r1.ebuild,6.41 KB, text/plain)
2016-12-29 22:39 UTC, Andrew Fowler
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Fowler 2016-12-29 22:38:35 UTC
Created attachment 457886 [details, diff]
Patch to Makefile.PL

For a while now if you try and build media-tv/xmltv with a subset of the drivers (e.g sd_json only) it will fail to build the correct item because Makefile.PL creates a makefile which skips options which don't have the requisite dependencies installed.
This means that when make is run, you get a different number of prompts depending on which perl modules are installed, so the 'one size fits all' yes/no answers answer the wrong questions.
Attached is a patch against Makefile.PL which seems to work in my config and a proposed 'r1' ebuild which I'm using here.
Comment 1 Andrew Fowler 2016-12-29 22:39:37 UTC
Created attachment 457888 [details]
Draft ebuild which uses patch
Comment 2 Andrew Fowler 2016-12-29 22:43:17 UTC
I haven't checked if the dependencies in the existing ebuild correctly match the perl prerequisites I commented out in the makefile patch. They seem to work for sd_json however...
Comment 3 Andrew Fowler 2018-01-07 14:43:29 UTC
Seems to have been resolved with by xmltv-0.5.70. (zz_sdjson)
The ebuild now lists missing dependencies rather than skipping prompts.
I guess this was an upstream change.
Comment 4 James Le Cuirot gentoo-dev 2018-02-03 00:00:26 UTC
I did the bump but I didn't change anything in this regard, except to remove the old commented out entries because the list was getting long and confusing. I don't think upstream changed anything either. Perhaps the list was out of sync when you tried it the first time. Even if it is correct now, the whole thing is very brittle and a better method is desirable. Unfortunately I didn't end up using xmltv as my OTA data is better.