New xscreensaver out, primarily a bugfix release. However, it introduces a typo that causes the build to fail. Patch attached, as well as ebuild bump + patch. Reproducible: Always Steps to Reproduce:
Created attachment 37446 [details] xscreensaver-4.17.ebuild
Created attachment 37447 [details, diff] xscreensaver-4.17-extrusion.patch
jwz has released 4.18 to fix this, as well as another problem. Please disregard the attachments here, and instead bump the 4.16 ebuild to 4.18.
I removed the epatch lines from the 4.16 ebuild and renamed it to 4.18 and everything went swimmingly well on my amd64. (gcc 3.4.1r2)
i saw a bug report on fd.o about xscreensaver and xorg 6.8.0 : https://freedesktop.org/bugzilla/show_bug.cgi?id=1312 basically, it talks about adding --with-gl explicitly to enable OpenGL based screensavers i don't know if it is a misdetection of GL libs/headers or if those are disabled by default does it deserve a new USE flag ? (opengl)
That bug was for 4.16 and has been changed to "Not a Bug". 4.18 compiles fine here on x86 and amd64 with xorg 6.8.0. I say push it up to portage ~x86 and ~amd64.
so, is there a chance we can see the 4.18 ebuild in portage ?
Agreed. Bumping to 4.18 from 4.16 without any modification compiles without error for x86.
another bump for great justice. This has been working for over 4 months now. Going to email liquidx directly.
How are you gentlemen!
xscreensaver 4.19 is out and works without modification
Andreas, how did you get 4.19 compiled cleanly from a bumped ebuild? The wording of the upstream RPM checking chunk in configure has been changed. Attached is a new norpm.patch and a modified ebuild to reflect that. Alastair? Still alive?
Created attachment 46145 [details] xscreensaver-4.19.ebuild
Created attachment 46146 [details, diff] xscreensaver-4.19-norpm.patch
4.19 16-Dec-2004 Removed support for GTK 1.x (everyone uses 2.x now.) Ryan maybe in ebuild you can remove gtk 1.x support ? And when I see this ebuild in portage ? ;)
Created attachment 46456 [details] xscreensaver-4.19.ebuild Removed gtk1 support (gtk USE flag). gtk2 is still in and default.
Thanks Sergey! I didn't notice because, well, nobody uses gtk1 :) FYI, here's a quick portage overlay howto for using these ebuilds in the meantime: mkdir -p /usr/local/portage/x11-misc/xscreensaver rsync -a /usr/portage/x11-misc/xscreensaver/files/ \ /usr/local/portage/x11-misc/xscreensaver/files/ # Download files from bugzilla. Place xscreensaver-4.19.ebuild into # /usr/local/portage/x11-misc/xscreensaver and xscreensaver-4.19-norpm.patch # into /usr/local/portage/x11-misc/xscreensaver/files ebuild /usr/portage/x11-misc/xscreensaver/xscreensaver-4.19.ebuild digest # Make sure "PORTDIR_OVERLAY=/usr/local/portage" is in /etc/make.conf emerge -pv xscreensaver # This should tell you it wants to upgrade # from the overlay directory
I tested this ebuild it work for me with +gnome +gtk2 +jpeg -kerberos -krb4 -offensive +opengl +pam -xinerama and thanks for ebuild mini-howto ;) but I do this operation too often and remember it a long time ago ;)
Hm it looks like this still isn't in portage. Has someone forgoten to update it?
Created attachment 46928 [details] bugzilla-xscreensaver.sh This file, when downloaded and ran, will set up your overlay directory and download the necessary files to emerge xscreensaver 4.19.
Frankly, I'm not sure why this bump has not been addressed. FYI, that blurb I posted above has a typo in it and will not work. To make things as easy as possible for all users who see this bug, I have uploaded a shell script that will set up everything to you. Examine it, download it and run it. Have fun!
I don't want gtk, motif, nor gdk-buf so I had to hack on the 4.19 ebuild a little. It appears to work O.K. for me. You might consider using some of this. --- xscreensaver-4.19.ebuild.orig 2005-01-16 23:52:46.141133416 -0500 +++ xscreensaver-4.19.ebuild 2005-01-17 00:01:19.098152096 -0500 @@ -4,7 +4,7 @@ inherit eutils -IUSE="pam kerberos krb4 gtk2 gnome opengl jpeg xinerama offensive" +IUSE="pam kerberos krb4 gtk2 gnome opengl jpeg xinerama offensive motif" DESCRIPTION="a modular screensaver for X11" SRC_URI="http://www.jwz.org/xscreensaver/${P}.tar.gz" @@ -30,7 +30,7 @@ >=dev-libs/glib-2 gnome? ( >=gnome-extra/yelp-2 ) ) - !gtk? ( x11-libs/openmotif ) + motif? ( x11-libs/openmotif ) pam? ( sys-libs/pam ) kerberos? ( krb4? ( >=app-crypt/mit-krb5-1.2.5 ) ) jpeg? ( media-libs/jpeg ) @@ -74,9 +74,13 @@ myconf="--with-fortune=/usr/bin/fortune" - use gtk2 \ - && myconf="${myconf} --without-motif --with-gtk --with-xml" \ - || myconf="${myconf} --with-motif --without-gtk --without-gdk-pixbuf" + if use gtk2 ; then + myconf="${myconf} --without-motif --with-gtk --with-xml" + elif use motif; then + myconf="${myconf} --with-motif --without-gtk --without-pixbuf" + else + myconf="${myconf} --without-motif --without-gtk --without-pixbuf" + fi use xinerama \ && myconf="${myconf} --with-xinerama-ext" \
Created attachment 48718 [details] xscreensaver-4.19.ebuild * Added patch by Kurt Hindenburg to use neither gtk2 nor motif. The result of this is that xscreensaver-demo is not built, so if the user does this, he is warned before the unpack. * Kurt's patch also fixed a few typos having to do with pixbuf and gtk. * The user is also warned if he uses motif and not gtk2. While the motif interface is still "supported" (bugs are fixed and whatnot), new features are not being added. While I don't think motif support should be removed completely as was in the ebuild comments, a warning was in order, as the motif interface is quite old.
Created attachment 48719 [details] bugzilla-xscreensaver.sh New ebuild download script. (Hey, this bug is approaching 6 months old)
Created attachment 48720 [details] xscreensaver-4.19.ebuild Oops, looks like there have been a few changes on 4.16 since this 4.19 ebuild "branched" from it. Added fix for bug #73022, and ppc64 keyword.
Created attachment 48721 [details] bugzilla-xscreensaver.sh New ebuild download script.
Man this has been going for a while.
Anything new? Is it so hard to commit it to the portage?
Another bump: Please commit the attached ebuild into portage. Thanks.
Should the status of this be changed from "enhancement" which seems to mean "ignore" to "normal"?
Created attachment 51966 [details] xscreensaver-4.20.ebuild New version, new features. See http://www.livejournal.com/users/jwz/445982.html RPM checking format changed again, new patch was needed.
Created attachment 51967 [details, diff] xscreensaver-4.20-norpm.patch
Created attachment 51968 [details] bugzilla-xscreensaver.sh Almost as easy as if it were actually in portage...
Created attachment 52005 [details] bugzilla-xscreensaver.sh Fixed a potentially disasterous error in the instructions at the bottom (should be "echo x11-misc/xscreensaver >> /etc/portage/package.keywords", not ">")
I just got word that if you use wget/whatnot to download bugzilla-xscreensaver.sh, it saves it in DOS format. sh does not like this. You must use dos2unix ("emerge dos2unix") to convert this before trying to execute it.
*** Bug 83192 has been marked as a duplicate of this bug. ***
I'll work on this seems liquidx is away for a bit and I have to tinker anyway.
Committed your 4.20 build and patch, with the addition of a dodoc on the README so people can see the change list. Thanks a lot, Finnie. jcp sends his love.
Actually one more change. We're going to use 'gtk' and not 'gtk2' flag. The 'gtk2' USE flag is only for when the user has a choice between gtk1 and gtk2, and to indicate a preference for the latter. The decision to enable gtk+ support at all rests with the regular 'gtk' flag.
