Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 603666 - "repoman commit" uses a different editor than "git commit"
Summary: "repoman commit" uses a different editor than "git commit"
Status: RESOLVED WONTFIX
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Repoman (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-12-25 03:25 UTC by Diogo Pereira
Modified: 2022-07-12 03:18 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Diogo Pereira 2016-12-25 03:25:28 UTC
repoman commit seems to always use the EDITOR enviroment variable.

git commit chooses from (in this order):
1. GIT_EDITOR environment variable
2. core.editor configuration variable
3. VISUAL environment variable
4. EDITOR environment variable

It would be nice for repoman commit to follow the behavior of git commit.
Comment 1 Arfrever Frehtes Taifersar Arahesis 2016-12-25 20:23:23 UTC
I am not sure if it is worth doing, and anyway it would require some refactoring, because currently get_new_commit_message() function (which has 'editor = os.environ.get("EDITOR")' line) is in generic code, but repoman supports also 'hg commit', 'svn commit' etc.
Comment 2 Diogo Pereira 2016-12-25 21:07:49 UTC
Well, preferring VISUAL to EDITOR would already be an improvement.
Comment 3 Brian Dolbec (RETIRED) gentoo-dev 2016-12-25 22:48:27 UTC
Some time during the stage3 rewrite (still on the to-do) it is my intention to create a config file for repoman.  It sounds like that could be a viable option for people to set.  Then it isn't restricted to just the one.
Comment 4 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-07-12 03:18:27 UTC
repoman support has been removed per bug 835013.

Please file a new bug (or, I suppose, reopen this one) if you feel this check is still applicable to pkgcheck and doesn't already exist.