Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 603254 - media-libs/graphite2-1.3.9[perl] fails POD Author Tests
Summary: media-libs/graphite2-1.3.9[perl] fails POD Author Tests
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Office Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-12-20 21:43 UTC by Kent Fredric (IRC: kent\n) (RETIRED)
Modified: 2016-12-20 23:13 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Fredric (IRC: kent\n) (RETIRED) gentoo-dev 2016-12-20 21:43:01 UTC
media-gfx/graphite2-1.3.9 uselessly doesn't fail any test that is meaningful.

It passes its entire core test suite, and passes a perl module loading test, but then fails on a cosmetic "you didn't document this function" test:

 * Test::Harness Jobs=4
# Testing Text::Gr2 0.01, Perl 5.022003, /usr/bin/perl
t/00-load.t ....... ok
#   Failed test 'Pod coverage on Text::Gr2'
#   at /usr/lib64/perl5/vendor_perl/5.22.3/Test/Pod/Coverage.pm line 133.
# Coverage for Text::Gr2 is 50.0%, with 2 naked subroutines:
#       gr_start_logging
#       gr_stop_logging
# Looks like you failed 1 test of 8.
t/pod-coverage.t .. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/8 subtests
t/pod.t ........... 
t/pod.t ........... 8/8
t/pod.t ........... ok


This is basically a case that can't be fixed by anyone other than upstream, and its not a functional problem from a users perspective.

This is why I pretty much standard nuke any such tests in dev-perl/ on sight.

I see this is a known problem in "src_test":

# Perl tests fail due to missing POD coverage...

But this is not very helpful to the end user, as it means their test suite fails when their software is fine.

Depending on what you're doing, a well placed:

   rm t/pod.t t/pod-coverage.t

Might be sufficient.

However, I locally tested this:

 src_test() {
 	cmake-multilib_src_test
 	if use perl; then
+		perl_rm_files "contrib/perl/t/pod.t" "contrib/perl/t/pod-coverage.t"
 		cd contrib/perl || die
 		# SRC_TEST=do
 		# Perl tests fail due to missing POD coverage...
 		perl-module_src_test
 	fi
 }

And the results were satisfactory.
Comment 1 Andreas K. Hüttel archtester gentoo-dev 2016-12-20 21:54:19 UTC
> 
> However, I locally tested this:
> 
>  src_test() {
>  	cmake-multilib_src_test
>  	if use perl; then
> +		perl_rm_files "contrib/perl/t/pod.t" "contrib/perl/t/pod-coverage.t"
>  		cd contrib/perl || die
>  		# SRC_TEST=do
>  		# Perl tests fail due to missing POD coverage...
>  		perl-module_src_test
>  	fi
>  }
> 
> And the results were satisfactory.

do it :)

test pass quota is better in dev-perl/* than anywhere else :D
Comment 2 Kent Fredric (IRC: kent\n) (RETIRED) gentoo-dev 2016-12-20 23:13:23 UTC
commit 80ac1452b5ee337fdd21187d0d504e9d06f10ab0
Author: Kent Fredric <kentnl@gentoo.org>
Date:   Wed Dec 21 12:09:37 2016 +1300

    media-gfx/graphite2: Fix POD Author Tests re: bug #603254
    
    POD Coverage tests serve no use to end user.