Bug 602784 – x11-drivers/xf86-video-virtualbox doesn't build with >=x11-base/xorg-server-1.19

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Johan Ymerson 2016-12-15 20:08:16 UTC]

Trying to build xf-video-virtualbox with XOrg 1.19 (currently masked) result in a build failure:
  CXX vboxvideo_drv_system - {R}/src/VBox/Additions/common/VBoxVideo/Modesetting.cpp
In file included from /usr/include/xorg/misc.h:117:0,
                 from /usr/include/xorg/xf86str.h:37,
                 from /var/tmp/portage/x11-drivers/xf86-video-virtualbox-5.1.10/work/VirtualBox-5.1.10/src/VBox/Additions/x11/vboxvideo/vboxvideo.h:107,
                 from /var/tmp/portage/x11-drivers/xf86-video-virtualbox-5.1.10/work/VirtualBox-5.1.10/src/VBox/Additions/x11/vboxvideo/helpers.c:23:
/usr/include/xorg/os.h:708:32: error: unknown type name ‘sigset_t’
 xthread_sigmask(int how, const sigset_t *set, sigset_t *oldest);
                                ^
In file included from /usr/include/xorg/misc.h:117:0,
                 from /usr/include/xorg/xf86str.h:37,
                 from /var/tmp/portage/x11-drivers/xf86-video-virtualbox-5.1.10/work/VirtualBox-5.1.10/src/VBox/Additions/x11/vboxvideo/vboxvideo.h:107,
                 from /var/tmp/portage/x11-drivers/xf86-video-virtualbox-5.1.10/work/VirtualBox-5.1.10/src/VBox/Additions/x11/vboxvideo/vboxvideo.c:56:
...

This is fixed upstream in what is to become VirtualBox-5.2 (https://www.virtualbox.org/ticket/16052), but that release seem to be far away.
It probably need to be back-ported to 5.1.10.
Here is a bug report on Debian about this:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=845644

[Comment 1 Johan Ymerson 2016-12-15 20:33:30 UTC]

This patch from opensuse seem to work:
https://build.opensuse.org/package/view_file/Virtualization/virtualbox/Fix_for_server_1.19.patch

[Comment 2 Joakim Tjernlund 2016-12-21 15:07:46 UTC]

Same for 5.12

Lars, have you seen this bug?

[Comment 3 Lars Wendler (Polynomial-C) (RETIRED) 2016-12-21 15:11:05 UTC]

(In reply to Joakim Tjernlund from comment #2)
> Same for 5.12
> 
> Lars, have you seen this bug?

Yes I have. Just had no time yet to look into this issue...

[Comment 4 Matt Turner 2017-01-17 23:43:37 UTC]

I cannot find xf86-video-virtualbox's source code hosting to check if this has been fixed upstream. euscan does not say that there is a newer release.

Lars, I need you to handle this one.

[Comment 5 Mart Raudsepp 2017-01-18 06:22:37 UTC]

I find https://www.virtualbox.org/browser/vbox/trunk/src/VBox/Additions/x11/vboxvideo but I don't see any xserver 1.19 compat there. Maybe the opensuse patch linked in earlier comment is OK?

[Comment 6 Johan Ymerson 2017-01-18 06:26:27 UTC]

Here is the upstream source code repository:
https://www.virtualbox.org/browser/vbox/trunk

They do not seam to have any branch for 5.1.
According to the upstream ticket, they will not fix this in 5.1.

[Comment 7 Lars Wendler (Polynomial-C) (RETIRED) 2017-01-25 01:21:51 UTC]

commit c5fca1c68a374712eb2a6b2fde6807c63b6a5f63
Author: Lars Wendler <[e-mail]>
Date:   Wed Jan 25 02:16:56 2017

    x11-drivers/xf86-video-virtualbox: Fixed build with >=x11-base/xorg-server-1.19

    This closes Gentoo bug #602784.

    Package-Manager: Portage-2.3.3, Repoman-2.3.1


Fixed in =x11-drivers/xf86-video-virtualbox-5.1.14 (and hopefully any possible later version).