Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 602362 - www-client/chromium-57.0.2946.0 fails to build with system ICU 58.1
Summary: www-client/chromium-57.0.2946.0 fails to build with system ICU 58.1
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Chromium Project
URL: https://bugs.chromium.org/p/chromium/...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-12-11 18:07 UTC by Mike Gilbert
Modified: 2017-01-05 12:40 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---

Attachments
build log (www-client:chromium-57.0.2946.0:20161211-013725.log.xz,409.82 KB, application/x-xz)
2016-12-11 18:07 UTC, Mike Gilbert 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Gilbert gentoo-dev 2016-12-11 18:07:19 UTC 
Created attachment 455872 [details]
build log

./../third_party/WebKit/Source/platform/text/CharacterEmoji.cpp: In function ‘void blink::applyPatternAndFreeze(icu::UnicodeSet*, const char*)’:
../../third_party/WebKit/Source/platform/text/CharacterEmoji.cpp:190:72: error: invalid initialization of non-const reference of type ‘UErrorCode&’ from an rvalue of type ‘UErrorCode’
   unicodeSet->applyPattern(icu::UnicodeString(pattern, -1, US_INV), err);
                                                                        ^
In file included from ../../third_party/WebKit/Source/platform/text/CharacterEmoji.cpp:7:0:
../../third_party/WebKit/Source/platform/text/ICUError.h:23:3: note:   after user-defined conversion: blink::ICUError::operator UErrorCode() const
   operator UErrorCode() const { return m_error; }
   ^
In file included from ../../third_party/WebKit/Source/platform/text/CharacterEmoji.cpp:11:0:
/usr/include/unicode/uniset.h:618:17: note:   initializing argument 2 of ‘icu::UnicodeSet& icu::UnicodeSet::applyPattern(const icu::UnicodeString&, UErrorCode&)’
     UnicodeSet& applyPattern(const UnicodeString& pattern,
                 ^
Comment 1 Mike Gilbert gentoo-dev 2016-12-11 18:23:27 UTC 
This was likely introduced here.

https://chromium.googlesource.com/chromium/src/+/e39da6eb22d95b38ffdb71873e48e15c408a470c%5E%21/
Comment 2 Paweł Hajdan, Jr. (RETIRED) gentoo-dev 2016-12-29 20:59:04 UTC 
Uploaded https://codereview.chromium.org/2602993002/ for upstream review.
Comment 3 Paweł Hajdan, Jr. (RETIRED) gentoo-dev 2016-12-30 16:49:55 UTC 
An alternative fix is now in review, https://codereview.chromium.org/2606183002/ .