Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 60214 - gentoo hotplug lacks blacklist.d
Summary: gentoo hotplug lacks blacklist.d
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All All
: High normal (vote)
Assignee: Greg Kroah-Hartman (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 59244
  Show dependency tree
 
Reported: 2004-08-13 04:43 UTC by Stefan Schweizer (RETIRED)
Modified: 2004-09-20 16:13 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
hotplug.functions.diff (hotplug.functions.diff,581 bytes, text/plain)
2004-08-13 10:07 UTC, Stefan Schweizer (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Schweizer (RETIRED) gentoo-dev 2004-08-13 04:43:24 UTC
Gentoo hotplug does not make use of the hotplug.d dir, there is an easy fix (from debian):

Replace this in /etc/hotplug/hotplug.functions:

            if grep -q "^$MODULE\$" $HOTPLUG_DIR/blacklist \
                    >/dev/null 2>&1; then

by this:
            if grep -q "^$(echo $MODULE|sed -e 's/[-_]/[-_]/g')\$" $HOTPLUG_DIR/blacklist \
                        $HOTPLUG_DIR/blacklist.d/* \
                    >/dev/null 2>&1; then



Thanks in advance
STefan Schweizer
Comment 1 Greg Kroah-Hartman (RETIRED) gentoo-dev 2004-08-13 09:32:44 UTC
I don't understand.  Your patch fixes a different issue (- vs _ in module names)
right?

What exactly is the problem that you are seeing with the hotplug scripts 
in gentoo?
Comment 2 Stefan Schweizer (RETIRED) gentoo-dev 2004-08-13 09:41:28 UTC
We need this for slmodem, because we do not want to change the /etc/hotplug/blacklist but place a file in /etc/hotplug/blacklist.d.

old one :
$HOTPLUG_DIR/blacklist

new one:
$HOTPLUG_DIR/blacklist \
$HOTPLUG_DIR/blacklist.d/*


now clear?
Comment 3 Greg Kroah-Hartman (RETIRED) gentoo-dev 2004-08-13 09:51:45 UTC
Ok, care to make up a patch that I can apply?
Comment 4 Stefan Schweizer (RETIRED) gentoo-dev 2004-08-13 10:07:21 UTC
Created attachment 37367 [details]
hotplug.functions.diff

Here is the patch ..
Comment 5 Stefan Schweizer (RETIRED) gentoo-dev 2004-08-14 23:53:32 UTC
I wonder why this patch is not in portage as debian uses it. Debian even uses
other usefull patches. Can you please sort them out and apply most of them?

Just 
wget http://ftp.debian.org/debian/pool/main/h/hotplug/hotplug_0.0.20040329-14.diff.gz
gzcat hotplug_0.0.20040329-14.diff.gz | patch -p1
cd debian/patches

in an empty directory. There are other usefull things like isapnp support in the hotplug package of debian. Can you please look into it, when you have time?

Stefan
Comment 6 Greg Kroah-Hartman (RETIRED) gentoo-dev 2004-08-15 00:25:29 UTC
It would be even better if debian pushed them upstream, as they do have
commit access to the hotplug cvs repository.

Anyway, I'll look at them when I get the time to make a new hotplug
release, thanks.
Comment 7 Greg Kroah-Hartman (RETIRED) gentoo-dev 2004-09-20 16:13:47 UTC
Thanks, I've added this upstream and it will show up in the next release.

I'll wait for the debian package to resync and send me the patches, as there
are a lot of patches added already that conflict with theirs.