Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 601604 - www-client/chromium-56.0.2924.14[system-ffmpeg] fails to build with media-video/ffmpeg-2
Summary: www-client/chromium-56.0.2924.14[system-ffmpeg] fails to build with media-vid...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Chromium Project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-12-04 16:05 UTC by Mike Gilbert
Modified: 2016-12-06 14:19 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build log (www-client:chromium-56.0.2922.1:20161120-230118.log.xz,142.34 KB, application/x-xz)
2016-12-04 16:05 UTC, Mike Gilbert
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Gilbert gentoo-dev 2016-12-04 16:05:03 UTC
Created attachment 455094 [details]
build log

../../media/filters/ffmpeg_demuxer.cc:212:15: error: ‘AVStream {aka struct AVStream}’ has no member named ‘codecpar’
Comment 2 Mike Gilbert gentoo-dev 2016-12-04 16:09:20 UTC
@media-video: Can you offer any advice (or even a patch) here?

In the mean time, I am changing the dependency to >=media-video/ffmpeg-3.
Comment 4 Alexis Ballier gentoo-dev 2016-12-04 19:55:28 UTC
(In reply to Mike Gilbert from comment #2)
> @media-video: Can you offer any advice (or even a patch) here?

I'd say use ->codec instead of ->codecpar with #ifdefery

this change might be harder to support in a backward compatible way than what you had posted on -dev some time ago

> In the mean time, I am changing the dependency to >=media-video/ffmpeg-3.

sounds like the best option for now

can you give an estimate on when you want to unmask chromium 56 ?
ffmpeg-3 has been masked long enough, not all packages have been ported yet but we cant force maintained packages to remain masked or apply backward compat patches just because of unmaintained ones either...
Comment 5 Mike Gilbert gentoo-dev 2016-12-04 20:16:11 UTC
(In reply to Alexis Ballier from comment #4)
> can you give an estimate on when you want to unmask chromium 56 ?

We generally unmask versions when they enter upstream's beta release channel. Chrome 55 was just promoted to the stable channel, so Chrome 56 will likely hit the beta channel in the next week or so.
Comment 6 Alexis Ballier gentoo-dev 2016-12-05 12:16:51 UTC
Here you go then:



commit a604b0b2c3a703e2d30e6e78136d4adca37885bd
Author: Alexis Ballier <aballier@gentoo.org>
Date:   Mon Dec 5 13:16:01 2016 +0100

    profiles/package.mask: unmask ffmpeg 3, needed by chromium (bug #601604)

diff --git a/profiles/package.mask b/profiles/package.mask
index 167e2494dc..f0d8aae55a 100644
--- a/profiles/package.mask
+++ b/profiles/package.mask
@@ -707,12 +707,6 @@ dev-lang/niecza-bin
 # Security mask, wrt bug #519730
 <app-emulation/ganeti-2.11.6-r2
 
-# Alexis Ballier <aballier@gentoo.org> (15 Feb 2016)
-# Breaks some of its reverse dependencies.
-# Bug 574788
->=media-video/ffmpeg-3.0
->=media-video/mplayer-1.3.0
-
 # James Le Cuirot <chewi@gentoo.org> (07 Feb 2016)
 # Masked until 2.0 final arrives, which hopefully won't depend on
 # commons-dbcp:0 as that requires Java 6. Note that the 2.0 in the
Comment 7 Oleh 2016-12-06 08:44:48 UTC
i'm sorry, but this unmask happened only because of chromium-56, which is still masked:

https://gitweb.gentoo.org/repo/gentoo.git/tree/profiles/package.mask#n364

and ffmmpeg-3 transition is still not complete:

https://bugs.gentoo.org/show_bug.cgi?id=574788

i don't think it's a good move.
Comment 8 Oleh 2016-12-06 08:45:52 UTC
and specifically chromium-56[system-ffmpeg]
Comment 9 Alexis Ballier gentoo-dev 2016-12-06 14:19:28 UTC
(In reply to Oleg from comment #7)
> i'm sorry, but this unmask happened only because of chromium-56, which is
> still masked:

no, the main reason is that the only packages left are unmaintained and we can't wait forever on those