Bug 601432 – sys-process/lsof: combined tests (via the test -a flag) don't get converted

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Mateusz Lenik 2016-12-02 10:48:25 UTC]

Default compilation includes HASUXSOCKEPT, which allows to find the other side of unix sockets, but it is disabled in the version existing in portage.

Output comparison:

-chrome    21645    m  200u     unix 0xffff922c0d977800      0t0 231121 type=STREAM
-chrome    21645    m  201u     unix 0xffff922d251bcb00      0t0  30788 type=SEQPACKET
+chrome    21645    m  200u     unix 0xffff922c0d977800      0t0 231121 type=STREAM ->INO=231120 6126,chrome,323u
+chrome    21645    m  201u     unix 0xffff922d251bcb00      0t0  30788 type=SEQPACKET ->INO=30789 6126,chrome,109u
 chrome    21645    m  204u     sock                0,7      0t0 233781 protocol: UNIX
-chrome    21645    m  210u     unix 0xffff922c9c0fa580      0t0 232195 type=STREAM
+chrome    21645    m  210u     unix 0xffff922c9c0fa580      0t0 232195 type=STREAM ->INO=232196 6209,chrome,530u

Lines with - are from the version from portage, lines with + are from the version built by running ./Configure linux && make and selecting the defaults.

[Comment 1 SpanKY 2016-12-07 17:04:29 UTC]

our sed on the test -r hackery missed cases where the code combined multiple tests into one like `test -r ... -a -r ...`.  i've changed the sed to first break up all the -a flags into distinct `test` commands so the next replacement can then operate on all of them independently.

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9ae2dc1bf97cbd4bd2db3000e610dedfdd4e3160

just updated the src_prepare section.