Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 60080 - Multi gnome terminal 1.6.2 doesn't compile under gcc 3.4 (amd64?)
Summary: Multi gnome terminal 1.6.2 doesn't compile under gcc 3.4 (amd64?)
Status: VERIFIED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] GNOME (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Please assign to toolchain
URL:
Whiteboard:
Keywords:
: 62161 (view as bug list)
Depends on:
Blocks:
 
Reported: 2004-08-11 12:34 UTC by Paul
Modified: 2004-11-28 03:45 UTC (History)
6 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Simple patch to get rid of the errors when compiling with gcc 3.4 (gcc34-multi-gnome-terminal-fix.patch,895 bytes, patch)
2004-08-27 22:33 UTC, Mark Loeser (RETIRED)
Details | Diff
Changes to ebuild (ebuild.patch,565 bytes, patch)
2004-08-27 22:34 UTC, Mark Loeser (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Paul 2004-08-11 12:34:48 UTC
I get the following error:

[snip]
gcc -DHAVE_CONFIG_H -I. -I. -I.. -I/usr/include                                         -I../intl                                       -I../intl                                       -I/usr/include/glib-1.2 -I/usr/lib/glib/include -I/usr/include/orbit-1.0 -I/usr/include/glib-1.2 -I/usr/lib/glib/include -I/usr/include/orbit-1.0                                           -I/usr/include/libglade-1.0 -I/usr/include/gnome-xml -I/usr/include/gnome-1.0 -DNEED_GNOMESUPPORT_H -I/usr/lib/gnome-libs/include -I/usr/include/glib-1.2 -I/usr/lib/glib/include -I/usr/include/orbit-1.0 -I/usr/include/gtk-1.2 -I/usr/X11R6/include                              -DGNOMESBINDIR=\""/usr/sbin"\"                              -DGNOME_TERMINAL_GLADEDIR=\""/usr/share/mgt/glade"\"            -DGNOMELOCALEDIR=\""/usr/share/locale\""  -I/usr/include/gtk-1.2 -I/usr/include/glib-1.2 -I/usr/lib/glib/include -I/usr/X11R6/include  -march=k8 -O2 -pipe -Wall -Wunused  -c vt.c
vt.c: In function `vt_pl':
vt.c:785: error: label at end of compound statement
vt.c: In function `vt_nl':
vt.c:809: error: label at end of compound statement
vt.c: In function `vt_tab_clear_cur':
vt.c:873: error: label at end of compound statement
vt.c: In function `vt_backtab':
vt.c:959: error: label at end of compound statement
vt.c: In function `vt_tab_index':
vt.c:983: error: label at end of compound statement
vt.c: In function `vt_deccharmode':
vt.c:2076: error: label at end of compound statement
vt.c:2079: error: label at end of compound statement
vt.c: At top level:
vt.c:506: warning: 'vt_erase_chars' defined but not used
vt.c:1602: warning: 'vt_vt100' defined but not used
make[3]: *** [vt.o] Error 1
make[3]: *** Waiting for unfinished jobs....
enhanced_gui.c:2389: warning: 'dummy_combo_popup_button_press' defined but not used
make[3]: Leaving directory `/var/tmp/portage/multi-gnome-terminal-1.6.2/work/multi-gnome-terminal-1.6.2/gnome-terminal'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/var/tmp/portage/multi-gnome-terminal-1.6.2/work/multi-gnome-terminal-1.6.2/gnome-terminal'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/var/tmp/portage/multi-gnome-terminal-1.6.2/work/multi-gnome-terminal-1.6.2'
make: *** [all-recursive-am] Error 2

!!! ERROR: x11-terms/multi-gnome-terminal-1.6.2 failed.
!!! Function src_compile, Line 41, Exitcode 2
!!! Compilation failed


I found this link which may be of help:


http://groups.google.com/groups?hl=en&lr=&ie=UTF-8&threadm=2krw3-2mn-11%40gated-at.bofh.it&rnum=1&prev=/groups%3Fq%3Dmulti%2520gnome%2520terminal%2520%2522error%253A%2520label%2520at%2520end%2520of%2520compound%2520statement%2522%26hl%3Den%26lr%3D%26ie%3DUTF-8%26sa%3DN%26tab%3Dwg

I'm running the amd64 gcc 3.4 build

ls -ld /etc/make.profile
lrwxrwxrwx  1 root root 40 Aug  8 17:37 /etc/make.profile -> /usr/portage/profiles/gcc34-amd64-2004.1


Reproducible: Always
Steps to Reproduce:
1.emerge multi-gnome-terminal
2.
3.

Actual Results:  
build failed

Expected Results:  
multi gnome terminal to be successfully emerged

emerge info multi-gnome-terminal
Portage 2.0.50-r9 (gcc34-amd64-2004.1, gcc-3.4.1, glibc-2.3.4.20040619-r1,
2.6.8-rc2-mm2)
=================================================================
System uname: 2.6.8-rc2-mm2 x86_64 4
Gentoo Base System version 1.5.2
ccache version 2.3 [enabled]
Autoconf: sys-devel/autoconf-2.59-r4
Automake: sys-devel/automake-1.8.5-r1
ACCEPT_KEYWORDS="amd64 ~amd64"
AUTOCLEAN="yes"
CFLAGS="-march=k8 -O2 -pipe"
CHOST="x86_64-pc-linux-gnu"
COMPILER="gcc3"
CONFIG_PROTECT="/etc /usr/X11R6/lib/X11/xkb /usr/kde/2/share/config
/usr/kde/3.2/share/config /usr/kde/3.3/share/config /usr/kde/3/share/config
/usr/lib/mozilla/defaults/pref /usr/share/config
/usr/share/texmf/dvipdfm/config/ /usr/share/texmf/dvips/config/
/usr/share/texmf/tex/generic/config/ /usr/share/texmf/tex/platex/config/
/usr/share/texmf/xdvi/ /var/qmail/control"
CONFIG_PROTECT_MASK="/etc/gconf /etc/terminfo /usr/X11R6/lib/X11/xkb /etc/env.d"
CXXFLAGS="-march=k8 -O2 -pipe"
DISTDIR="/usr/portage/distfiles"
FEATURES="autoaddcvs ccache"
GENTOO_MIRRORS="http://gentoo.oregonstate.edu
http://distro.ibiblio.org/pub/Linux/distributions/gentoo"
MAKEOPTS="-j2"
PKGDIR="/usr/portage/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY=""
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="X Xaw3d aalib acpi alsa amd64 apache2 apm arts avi berkdb bonobo ccache cdr
cjk crypt cups curl dga directfb dvd emacs encode esd evo fbcon foomaticdb gb gd
gdbm ggi gif gkthtml gnome gphoto2 gpm gtk gtk2 guile imagemagick imap imlib
innodb jpeg kde libg++ libgda libwww mbox mikmod motif mozilla mpeg ncurses nls
nptl odbc oggvorbis opengl oss pam pda pdflib perl png ppds python qt quicktime
readline scanner sdl slang spell ssl tcltk tcpd tetex tiff truetype unicode usb
wmf xinerama xml2 xmms xv zlib"
Comment 1 Robert Moss (RETIRED) gentoo-dev 2004-08-19 14:46:48 UTC
Looks like a dead easy one that. Removing some semi-colons and so on. I'll take a look in a bit.
Comment 2 ronmon 2004-08-26 08:00:42 UTC
I made a couple half-hearted attempts at putting this into the ebuild before giving up and doing it manually. What worked for me was a bit "round-about", but it works.

First, I saved the patch as 'multi-gnome-terminal_1.6.2-8.0.0.1.amd64.patch'. Then,

# ebuild /usr/portage/x11-terms/multi-gnome-terminal/multi-gnome-terminal-1.6.2.ebuild unpack

# cd /var/tmp/portage/multi-gnome-terminal-1.6.2/work/multi-gnome-terminal-1.6.2

# patch -p1 < [/path/to/]multi-gnome-terminal_1.6.2-8.0.0.1.amd64.patch

What that did was create 'debian/patches/00006_gcc-3.4.patch', which I applied and then continued building.

# cd ./gnome-terminal

# patch -p0 < ../debian/patches/00006_gcc-3.4.patch

# ebuild /usr/portage/x11-terms/multi-gnome-terminal/multi-gnome-terminal-1.6.2.ebuild compile

# ebuild /usr/portage/x11-terms/multi-gnome-terminal/multi-gnome-terminal-1.6.2.ebuild install

# ebuild /usr/portage/x11-terms/multi-gnome-terminal/multi-gnome-terminal-1.6.2.ebuild qmerge

I builds and runs splendidly. Surely someone smarter than me can figure out the right way to stick it into an ebuild.
Comment 3 Mark Loeser (RETIRED) gentoo-dev 2004-08-27 22:33:19 UTC
Created attachment 38364 [details, diff]
Simple patch to get rid of the errors when compiling with gcc 3.4

This is an easy one to get rid of the errors.  The attached patch should do it.
Comment 4 Mark Loeser (RETIRED) gentoo-dev 2004-08-27 22:34:05 UTC
Created attachment 38365 [details, diff]
Changes to ebuild

And to make it even easier, here is the changes to the ebuild.
Comment 5 foser (RETIRED) gentoo-dev 2004-08-30 01:44:17 UTC
*** Bug 62161 has been marked as a duplicate of this bug. ***
Comment 6 Hiel Van Campen 2004-09-03 18:39:53 UTC
I just tried to build MGT and the patch is failing to apply and the emerge dies in " vt.c ". Manuallly editing " vt.c " worked. 

Portage 2.0.50-r10 (gcc34-x86-2004.2, gcc-3.4.1, glibc-2.3.4.20040808-r0, 2.6.8-gentoo-r2)
=================================================================
System uname: 2.6.8-gentoo-r2 i686 AMD Athlon(tm) XP 2000+
Gentoo Base System version 1.5.2
Autoconf: sys-devel/autoconf-2.59-r4
Automake: sys-devel/automake-1.8.5-r1
ACCEPT_KEYWORDS="x86 ~x86"
AUTOCLEAN="yes"
CFLAGS="-march=athlon-xp -fomit-frame-pointer -O2 -falign-jumps -pipe"
CHOST="i686-pc-linux-gnu"
COMPILER=""
CONFIG_PROTECT="/etc /usr/X11R6/lib/X11/xkb /usr/kde/2/share/config /usr/kde/3.3/share/config:/usr/kde/3.3/env:/usr/kde/3.3/shutdown /usr/kde/3/share/config /usr/lib/mozilla/defaults/pref /usr/share/config /var/qmail/control"
CONFIG_PROTECT_MASK="/etc/gconf /etc/terminfo /etc/env.d"
CXXFLAGS="-march=athlon-xp -fomit-frame-pointer -O2 -falign-jumps -pipe"
DISTDIR="/usr/portage/distfiles"
FEATURES="autoaddcvs buildpkg ccache sandbox userpriv"
GENTOO_MIRRORS="ftp://ftp.ucsb.edu/pub/mirrors/linux/gentoo/ http://128.213.5.34/gentoo/"
MAKEOPTS="-j3 "
PKGDIR="/usr/portage/packages"
PORTAGE_TMPDIR="/home/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY=""
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="X apm arts async autofs avi berkdb chroot crypt cups dillo doc encode esd foomaticdb freetype gdbm gif gpm gtk gvim hpijs imagemagick imlib jpeg libg++ libwww mad mikmod motif mozilla mpeg ncurses nptl oggvorbis opengl oss pam pdflib perl png python qt quicktime readline samba sdl slang snmp spell ssl svga tcpd truetype type1 unicode x86 xml2 xmms xv zlib"
Comment 7 Hiel Van Campen 2004-09-03 18:56:10 UTC
Oops the ebuild doesnt seem to have the ebuild patch yet.
Comment 8 Hiel Van Campen 2004-09-03 22:07:56 UTC
The ebuild patch works on my system.
Comment 9 foser (RETIRED) gentoo-dev 2004-09-05 00:11:11 UTC
afaik lu_zera already added a gcc34 patch.. lu_zero, can you confirm ?
Comment 10 Luca Barbato gentoo-dev 2004-09-05 12:52:52 UTC
multi-gnome-terminal/files/multi-gnome-terminal-1.6.2-gcc-3.4.patch
is present and pvdabeel fixed another issue in the mean time

the 1.6.2-r1 should work fine.
Comment 11 will 2004-09-05 13:19:05 UTC
confirming that it works under gcc 3.4 on x86
Comment 12 Simon Stelling (RETIRED) gentoo-dev 2004-11-28 03:29:53 UTC
work here too... i think we can close this one though
Comment 13 Luca Barbato gentoo-dev 2004-11-28 03:45:15 UTC
Closing