Emerging net-proxy/dante-1.4.0-r2 always fails using upnp libraries (USE=upnp) when MINIUPNPC_API_VERSION >= 14. The error is: upnp.c:153:15: error: too few arguments to function ‘upnpDiscover’ dev = upnpDiscover(UPNP_DISCOVERYTIME_MS, ^ In file included from ../include/upnp.h:47:0, from upnp.c:49: /usr/include/miniupnpc/miniupnpc.h:62:1: note: declared here upnpDiscover(int delay, const char * multicastif, ^ Makefile:583: recipe for target 'upnp.lo' failed make[1]: *** [upnp.lo] Error 1 make[1]: *** Waiting for unfinished jobs.... In file included from /usr/include/sys/types.h:25:0, from ../include/osdep.h:71, from ../include/common.h:56, from util.c:45: /usr/include/features.h:148:3: warning: #warning "_BSD_SOURCE and _SVID_SOURCE are deprecated, use _DEFAULT_SOURCE" [-Wcpp] # warning "_BSD_SOURCE and _SVID_SOURCE are deprecated, use _DEFAULT_SOURCE" ^ libtool: compile: x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I../include -I../include -I../libscompat -D_XOPEN_SOURCE=600 -D_XOPEN_SOURCE_EXTENDED -D_BSD_SOURCE -DDEBUG=0 -DSOCKS_CLIENT=1 -DSOCKS_SERVER=0 -DSOCKSLIBRARY_DYNAMIC=0 -DSTANDALONE_UNIT_TEST=0 -march=native -mtune=native -O2 -pipe -g -O2 -ggdb -pipe -c ../libscompat/strlcpy.c -fPIC -DPIC -o .libs/strlcpy.o libtool: compile: x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I../include -I../include -I../libscompat -D_XOPEN_SOURCE=600 -D_XOPEN_SOURCE_EXTENDED -D_BSD_SOURCE -DDEBUG=0 -DSOCKS_CLIENT=1 -DSOCKS_SERVER=0 -DSOCKSLIBRARY_DYNAMIC=0 -DSTANDALONE_UNIT_TEST=0 -march=native -mtune=native -O2 -pipe -g -O2 -ggdb -pipe -c ../libscompat/strvis.c -fPIC -DPIC -o .libs/strvis.o In file included from /usr/include/sys/types.h:25:0, from ../include/osdep.h:71, from ../libscompat/strlcpy.c:7: /usr/include/features.h:148:3: warning: #warning "_BSD_SOURCE and _SVID_SOURCE are deprecated, use _DEFAULT_SOURCE" [-Wcpp] # warning "_BSD_SOURCE and _SVID_SOURCE are deprecated, use _DEFAULT_SOURCE" ^ In file included from /usr/include/sys/types.h:25:0, from ../include/osdep.h:71, from ../libscompat/strvis.c:7: /usr/include/features.h:148:3: warning: #warning "_BSD_SOURCE and _SVID_SOURCE are deprecated, use _DEFAULT_SOURCE" [-Wcpp] # warning "_BSD_SOURCE and _SVID_SOURCE are deprecated, use _DEFAULT_SOURCE" ^ make[1]: Leaving directory '/tmp/portage/net-proxy/dante-1.4.0-r2/work/dante-1.4.0/lib' Makefile:425: recipe for target 'all-recursive' failed make: *** [all-recursive] Error 1 Reproducible: Always Steps to Reproduce: 1. emerge =net-libs/miniupnpc-1.9.20151008 2. USE=upnp emerge =net-proxy/dante-1.4.0-r2 Actual Results: Makefile:425: recipe for target 'all-recursive' failed make: *** [all-recursive] Error 1 * ERROR: net-proxy/dante-1.4.0-r2::gentoo failed (compile phase): * emake failed * * If you need support, post the output of `emerge --info '=net-proxy/dante-1.4.0-r2::gentoo'`, * the complete build log and the output of `emerge -pqv '=net-proxy/dante-1.4.0-r2::gentoo'`. * The complete build log is located at '/tmp/portage/net-proxy/dante-1.4.0-r2/temp/build.log'. * The ebuild environment file is located at '/tmp/portage/net-proxy/dante-1.4.0-r2/temp/environment'. * Working directory: '/tmp/portage/net-proxy/dante-1.4.0-r2/work/dante-1.4.0' * S: '/tmp/portage/net-proxy/dante-1.4.0-r2/work/dante-1.4.0' >>> Failed to emerge net-proxy/dante-1.4.0-r2, Log file: >>> '/tmp/portage/net-proxy/dante-1.4.0-r2/temp/build.log' * Messages for package net-proxy/dante-1.4.0-r2: * ERROR: net-proxy/dante-1.4.0-r2::gentoo failed (compile phase): * emake failed * * If you need support, post the output of `emerge --info '=net-proxy/dante-1.4.0-r2::gentoo'`, * the complete build log and the output of `emerge -pqv '=net-proxy/dante-1.4.0-r2::gentoo'`. * The complete build log is located at '/tmp/portage/net-proxy/dante-1.4.0-r2/temp/build.log'. * The ebuild environment file is located at '/tmp/portage/net-proxy/dante-1.4.0-r2/temp/environment'. * Working directory: '/tmp/portage/net-proxy/dante-1.4.0-r2/work/dante-1.4.0' * S: '/tmp/portage/net-proxy/dante-1.4.0-r2/work/dante-1.4.0' Portage 2.3.0 (python 3.4.5-final-0, default/linux/amd64/13.0/developer, gcc-4.9.3, glibc-2.22-r4, 4.4.26-gentoo x86_64) ================================================================= System uname: Linux-4.4.26-gentoo-x86_64-Intel-R-_Core-TM-_i7-5820K_CPU_@_3.30GHz-with-gentoo-2.2 KiB Mem: 16332920 total, 9783872 free KiB Swap: 6291452 total, 6291452 free Timestamp of repository gentoo: Thu, 24 Nov 2016 20:00:01 +0000 sh bash 4.3_p48 ld GNU ld (Gentoo 2.25.1 p1.1) 2.25.1 app-shells/bash: 4.3_p48::gentoo dev-java/java-config: 2.2.0-r3::gentoo dev-lang/perl: 5.24.1_rc4::gentoo dev-lang/python: 2.7.12::gentoo, 3.4.5::gentoo dev-util/cmake: 3.5.2-r1::gentoo dev-util/pkgconfig: 0.28-r2::gentoo sys-apps/baselayout: 2.2::gentoo sys-apps/openrc: 0.22.4::gentoo sys-apps/sandbox: 2.10-r1::gentoo sys-devel/autoconf: 2.13::gentoo, 2.69::gentoo sys-devel/automake: 1.11.6-r1::gentoo, 1.12.6::gentoo, 1.13.4::gentoo, 1.14.1::gentoo, 1.15::gentoo sys-devel/binutils: 2.25.1-r1::gentoo sys-devel/gcc: 4.8.5::gentoo, 4.9.3::gentoo sys-devel/gcc-config: 1.7.3::gentoo sys-devel/libtool: 2.4.6::gentoo sys-devel/make: 4.1-r1::gentoo sys-kernel/linux-headers: 4.3::gentoo (virtual/os-headers) sys-libs/glibc: 2.22-r4::gentoo Repositories: gentoo location: /subsys/usr/portage sync-type: rsync sync-uri: rsync://rsync.gentoo.org/gentoo-portage priority: -1000 haskell location: /var/lib/layman/haskell sync-type: laymansync sync-uri: git://github.com/gentoo-haskell/gentoo-haskell.git masters: gentoo priority: 50 java location: /var/lib/layman/java sync-type: laymansync sync-uri: git://anongit.gentoo.org/proj/java.git masters: gentoo priority: 50 ACCEPT_KEYWORDS="amd64" ACCEPT_LICENSE="* -@EULA" CBUILD="x86_64-pc-linux-gnu" CFLAGS="-march=native -mtune=native -O2 -pipe" CHOST="x86_64-pc-linux-gnu" CONFIG_PROTECT="/etc /usr/lib64/libreoffice/program/sofficerc /usr/share/gnupg/qualified.txt /usr/share/maven-bin-3.0/conf /usr/share/maven-bin-3.3/conf" CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/php/apache2-php5.6/ext-active/ /etc/php/cgi-php5.6/ext-active/ /etc/php/cli-php5.6/ext-active/ /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c" CXXFLAGS="-march=native -mtune=native -O2 -pipe" DISTDIR="/usr/portage/distfiles" FCFLAGS="-O2 -pipe" FEATURES="assume-digests binpkg-logs collision-protect config-protect-if-modified distlocks ebuild-locks fixlafiles merge-sync news parallel-fetch parallel-install preserve-libs protect-owned sandbox sfperms sign splitdebug strict test-fail-continue unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr" FFLAGS="-O2 -pipe" GENTOO_MIRRORS="http://ftp-stud.hs-esslingen.de/pub/Mirrors/gentoo/ rsync://ftp.jaist.ac.jp/pub/Linux/Gentoo/ ftp://ftp.jaist.ac.jp/pub/Linux/Gentoo/ ftp://gentoo.imj.fr/pub/gentoo/ ftp://ftp.uni-erlangen.de/pub/mirrors/gentoo" LANG="it_IT.utf8" LDFLAGS="-Wl,--hash-style=gnu -Wl,-O1 -Wl,--as-needed" MAKEOPTS="-j14" PKGDIR="/usr/portage/packages" PORTAGE_CONFIGROOT="/" PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git" PORTAGE_TMPDIR="/tmp" USE="X a52 aac acl acpi aes aio alsa amd64 avx avx2 bash-completion berkdb blueray bluetooth branding bzip2 cairo cdda cddb cdparanoia cdr cli consolekit corefonts cracklib crypt css cups cxx dbus dirac dri dts dv dvb dvd dvdr emboss encode exif fam fbcon ffmpeg firefox flac fma3 fontconfig foomaticdb fortran freetds gdbm gif gimp git glamor gnutls gpm gtk gzip hddtemp hoogle hscolour iconv icu imagemagick imap ipv6 jabber java jpeg jpeg2k kvm lame latex lcms ldap libcaca libffi libnotify live lm_sensors lzma lzo mad matroska mime mmx mmxext mng modules mozilla mp3 mp4 mpeg multilib mysql ncurses nls nptl odbc ogg opengl openmp optimization pam pango pcre pdf php png policykit popcnt postscript ppds qemu qt3support qt4 quicktime raw rdesktop readline rss ruby samba sasl scanner schroendiger sdl seccomp session smartcard smp snmp sockets socks5 sound spell sqlite sse sse2 sse3 sse4_1 sse4_2 ssl ssse3 startup-notification strong-optimization svg symlink syslog tcpd theora threads tiff truetype udev udisks unicode upnp upnp-av upower usb v4l vhost vim-syntax vorbis webkit wmf wxwidgets x264 x265 xattr xcb xcomposite xft xml xmpp xpm xscreensaver xv xvid zlib zsh-completion" ABI_X86="64" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump author" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="aes avx avx2 fma3 mmx mmxext popcnt sse sse2 sse3 sse4_1 sse4_2 ssse3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ublox ubx" GRUB_PLATFORMS="efi-64" INPUT_DEVICES="evdev" KERNEL="linux" L10N="it en-US" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LINGUAS="it en" NGINX_MODULES_HTTP="fastcgi fancyindex echo dav gzip gzip_static memcached access auth_basic auth_pam perl rewrite upload upload_progress userid uwsgi xslt memc passenger scgi ssi auth_request cache_purge gunzip headers_more sub" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php5-6" PYTHON_SINGLE_TARGET="python2_7" PYTHON_TARGETS="python3_4 python2_7" QEMU_SOFTMMU_TARGETS="i386 ppc ppc64 x86_64" QEMU_USER_TARGETS="arm i386 x86_64" RUBY_TARGETS="ruby20 ruby21" SANE_BACKENDS="mustek_usb" USERLAND="GNU" VIDEO_CARDS="nvidia" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account" USE_PYTHON="3.4 2.7" Unset: CC, CPPFLAGS, CTARGET, CXX, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LC_ALL, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPT
Created attachment 454268 [details, diff] Patch to eliminate the tedious warning This patch avoids annoying warning during compilation: /usr/include/features.h:148:3: warning: #warning "_BSD_SOURCE and _SVID_SOURCE are deprecated, use _DEFAULT_SOURCE" [-Wcpp] _BSD_SOURCE and _SVID_SOURCE are indeed deprecated in features.h, we have to use _DEFAULT_SOURCE instead.
Created attachment 454270 [details, diff] Patch to eliminate build error that prevent compiling This patch fixes wrong parameters number in function call: upnpDiscover() in upnp.c:153:15 With API version 14 of miniupnpc.h, a new 'TTL' argument was added to function signature: miniupnpc.h ChangeLog ===================== miniupnpc.h add ttl argument to upnpDiscover() upnpDiscoverAll() upnpDiscoverDevice() upnpDiscoverDevices() getDevicesFromMiniSSDPD() : connectToMiniSSDPD() / disconnectFromMiniSSDPD() requestDevicesFromMiniSSDPD() / receiveDevicesFromMiniSSDPD() updated macro : #define MINIUPNPC_API_VERSION 14
Side note: I chose the value 2 for the TTL parameter, according to its default value in minupnpc.h documentation (row 60): * if 0, the discovery will stop with the first type returning results. * TTL should default to 2. */ https://github.com/miniupnp/miniupnp/blob/dadbc62f80fa466d8580d268760efaa723661d19/miniupnpc/miniupnpc.h
Hi guys, I submitted the same patch upstream, and this is their kind reply: ---- Dear Michele Testa, Thank you for the bug report, a change has been submitted for the compilation error based on your patch and should be included in the next version of Dante. With kind regards, Karl-Andre' Skevik Inferno Nettverk A/S ---- So we could use the proposed patch until their next upstream release will finally fix the bug. Thanks 4 all, mk
We appear to apply the required patch in 1.4.1-r1.
