Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 600550 - sys-apps/sandbox with CFLAGS="-DNDEBUG" fails to build
Summary: sys-apps/sandbox with CFLAGS="-DNDEBUG" fails to build
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Sandbox (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Sandbox Maintainers
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2016-11-23 03:25 UTC by Guenther Brunthaler
Modified: 2021-10-18 04:39 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch fixing the problem (sandbox-2.10-NDEBUG.patch,574 bytes, patch)
2016-11-23 03:25 UTC, Guenther Brunthaler
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Guenther Brunthaler 2016-11-23 03:25:51 UTC
Created attachment 454096 [details, diff]
Patch fixing the problem

When using "release"-version CFLAGS containing "-D NDEBUG", sys-apps/sandbox checks for NDEBUG but handles it incorrectly.

There are 2 problems:

1. It replaces a function call by a no-op macro, but the macro has a different number of arguments than the function call.

2. It also uses the macro to expand the function name when compiling the function definition, resulting in a missing function name.

The patch fixes those problems.
Comment 1 SpanKY gentoo-dev 2021-10-18 04:39:21 UTC
hmm, guess i forgot to close this.  it was (partially) merged shortly after this was filed:
https://gitweb.gentoo.org/proj/sandbox.git/commit/?id=87d6537245b6f7cbf028e4c0e187cda7484729f0