Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 600334 - =app-emulation/docker-registry-2.5.1 does not install golang sources
Summary: =app-emulation/docker-registry-2.5.1 does not install golang sources
Status: RESOLVED WORKSFORME
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Zac Medico
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-11-20 18:22 UTC by Manuel Rüger (RETIRED)
Modified: 2016-11-29 23:00 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Manuel Rüger (RETIRED) gentoo-dev 2016-11-20 18:22:30 UTC
As other packages seem to depend on parts of docker/distribution, it would be great if docker-registry would install those sources as well.
Comment 1 Zac Medico gentoo-dev 2016-11-20 19:27:23 UTC
For many golang packages, I don't think it's very practical to install the sources. They are typically unused, since most packages bundle their dependencies in a vendor directory.

In cases when dependencies are not provided in a vendor directory, I typically make the ebuild pull in the dependencies via SRC_URI, and unpack them in a temporary GOPATH. For example, the docker-swarm-1.2.5 ebuild uses this approach, since the vendor directory doesn't include all of the dependencies.

I know that bundling dependencies may not be an ideal solution, but it's very practical because it aligns with upstream's tendency to vendor dependencies.

Note that docker registry includes a large number of vendored dependencies:

https://github.com/docker/distribution/tree/master/vendor

Will we have to install all those vendor sources in /usr/lib/go-gentoo as well? I don't think it would be very practical.
Comment 2 Manuel Rüger (RETIRED) gentoo-dev 2016-11-29 23:00:52 UTC
Okay, that works for me. Thanks!