Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 600162 - kde-apps/okular: rename ebook USE flag to epub
Summary: kde-apps/okular: rename ebook USE flag to epub
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo KDE team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-11-18 12:29 UTC by Sod off! I am no loger here!
Modified: 2017-06-24 14:40 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sod off! I am no loger here! 2016-11-18 12:29:48 UTC 
When enabling epub support using the epub USE-flag it does not apply to okular (kde-apps/okular-16.08.2) as the USE-flag "ebook" is used instead. 

According to Okular documentation ebook-tools is the library used to parse epub files, and usage of ebook-tools for other purposes is not mentioned. 

I suggest that the epub USE-flag shall be used also in okular ebuild to enable epub-support. This is what at least I expect by such a USE-flag, especially since epub is a valid USE-flag for kde-frameworks/kfilemetadata.

Reference: https://okular.kde.org/formats.php
Comment 1 Michael Palimaka (kensington) gentoo-dev 2016-11-19 10:01:08 UTC 
Fine with me, anyone else want to chime in?
Comment 2 Johannes Huber (RETIRED) gentoo-dev 2016-11-19 18:28:07 UTC 
Imho ebook sounds more natural.
Comment 3 Michael Palimaka (kensington) gentoo-dev 2016-11-19 18:29:48 UTC 
It's a little bit misleading - ebooks can come in many formats and contrary to the name ebook-tools really only ships libepub.
Comment 4 Andreas Sturmlechner gentoo-dev 2017-05-26 21:00:31 UTC 
Let's change this to be consistent with frameworks?
Comment 5 Andreas Sturmlechner gentoo-dev 2017-06-24 14:40:32 UTC 
Fixed in git commit 60996c376c373d5774a0fd21d3e1d420a77ac1a5.