Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 600116 - >=net-misc/nextcloud-client-2.2.4 USE=dolphin does not integrate with dolphin
Summary: >=net-misc/nextcloud-client-2.2.4 USE=dolphin does not integrate with dolphin
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: AMD64 Linux
: Normal normal (vote)
Assignee: Bernard Cafarelli
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-11-17 17:00 UTC by Felix Tiede
Modified: 2016-12-16 09:59 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Integrate nextcloud-client's dolphin plugin correctly. (dolphinplugin.patch,727 bytes, patch)
2016-11-17 17:00 UTC, Felix Tiede
Details | Diff
General OEM theming patch (oem_integration.patch,1.57 KB, patch)
2016-11-19 10:19 UTC, Felix Tiede
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Felix Tiede 2016-11-17 17:00:37 UTC
Created attachment 453670 [details, diff]
Integrate nextcloud-client's dolphin plugin correctly.

Despite the service libraries being built and installed, the usual context menu actions as known from net-misc/owncloud-client do not appear.

This is an issue with the client theming which generates libraries named after the theme in use but does not take these names into account when installing the necessary .desktop files.

I don't know if this can or will be fixed upstream, as the binaries and their generation are entirely in the hands of ownCloud, while the the problem does only appear with a themed client using different binary names (which, in this case, is Nextcloud's part).

The attached quick'n'dirty patch solves the problem downstream by modifying the .desktop file after unpacking all upstream components. It is no patch to be used generally but only for the current Nextcloud theme.
Comment 1 Felix Tiede 2016-11-19 10:19:36 UTC
Created attachment 453772 [details, diff]
General OEM theming patch

This new patch correctly integrates OEM theming with the dolphin plugin and is applicable to net-misc/owncloud-client as well without changing functionality.

The patch is tested against net-misc/nextcloud-client-2.2.4-r1 and net-misc/owncloud-client-2.2.4 and works as expected. A corresponding pull-request upstream showed no conflict with owncloud-client master branch.
Comment 2 Bernard Cafarelli gentoo-dev 2016-11-29 12:39:39 UTC
Thanks for the report and patch!

As it is in the owncloud code itself, yes I am not sure how upstream can go with it. But I can add this downstream in the meantime
Comment 3 Bernard Cafarelli gentoo-dev 2016-11-29 13:32:09 UTC
Added in -r2, thanks for the patch!
Comment 4 Felix Tiede 2016-12-15 11:42:52 UTC
Merged into upstream master branch (net-misc/owncloud-client and thus also into net-misc/nextcloud-client).
No idea when it will be released, though.
Comment 5 Bernard Cafarelli gentoo-dev 2016-12-16 09:59:26 UTC
Thanks for the update and pushing this upstream! At least Gentoo users have this fixed in current ebuild until a new release