Bug 59984 – gentoo-dev-sources-2.6.7-r13 does not build on sparc because of a syntax problem in flash.c

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Ferris McCormick (RETIRED) 2004-08-10 12:39:35 UTC]

The kernel sources from gentoo-dev-sources-2.6.7-r13 will most likely not build on sparc.
Difficulty is at drivers/sbus/char/flash.c, line 128:  On an error condition from
flash_read, the code tries to do up(s), but 's' is not declared.  It appears that
it should be doing up(&flash_mutex).

This source module is used (at least) for CONFIG_OBP_FLASH=m, which is default for sparc.

Bug opened at greg k-h's request.

Reproducible: Always
Steps to Reproduce:
1.Make sure your configure file has CONFIG_OBP_FLASH=m (or y)
2.make vmlinux modules
3.

Actual Results:  
Syntax error exit compiling flash.c, s is undeclared.

Expected Results:  
Built a kernel + modules.

Problem is first present with -r12 & persists to -r13. -r11 builds fine with the
same .config file.  Here is one system I've seen it on (but it's not system
dependent):
=======================================================
fmccor@antaresia:/usr/src/linux [226]% emerge info
Portage 2.0.51_pre17 (default-sparc64-1.4, gcc-3.3.4, glibc-2.3.3.20040420-r0,
2.6.7-gentoo-r11 sparc64 sun4u)
=================================================================
System uname: 2.6.7-gentoo-r11 sparc64 sun4u
Gentoo Base System version 1.4.16
ccache version 2.3 [disabled]
Autoconf: sys-devel/autoconf-2.59-r4
Automake: sys-devel/automake-1.8.3
Binutils: sys-devel/binutils-2.14.90.0.7-r4
Headers:  sys-kernel/linux-headers-2.4.19-r1,sys-kernel/linux-headers-2.4.23
Libtools: sys-devel/libtool-1.5.2-r5
ACCEPT_KEYWORDS="sparc"
AUTOCLEAN="yes"
CFLAGS="-mcpu=ultrasparc -mtune=ultrasparc -O2 -pipe"
CHOST="sparc-unknown-linux-gnu"
COMPILER="gcc3"
CONFIG_PROTECT="/etc /usr/X11R6/lib/X11/xkb /usr/kde/2/share/config
/usr/kde/3.1/share/config /usr/kde/3.2/share/config /usr/kde/3/share/config
/usr/lib/mozilla/defaults/pref /usr/share/config
/usr/share/texmf/dvipdfm/config/ /usr/share/texmf/dvips/config/
/usr/share/texmf/tex/generic/config/ /usr/share/texmf/tex/platex/config/
/usr/share/texmf/xdvi/ /var/qmail/control"
CONFIG_PROTECT_MASK="/etc/gconf /etc/terminfo /etc/env.d"
CXXFLAGS="-mcpu=ultrasparc -mtune=ultrasparc -O2 -pipe -Wno-deprecated"
DISTDIR="/usr/portage/distfiles"
FEATURES="cvs sandbox"
GENTOO_MIRRORS="http://mirror.datapipe.net/gentoo
ftp://ftp.gtlib.cc.gatech.edu/pub/gentoo ftp://ftp.ndlug.nd.edu/pub/gentoo/
ftp://ftp.ussg.iu.edu/pub/linux/gentoo http://mirrors.tds.net/gentoo"
MAKEOPTS="-j3"
PKGDIR="/usr/portage/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="sparc X arts avi berkdb crypt cups dillo encode fbcon foomaticdb gdbm gif
gpm gtk imlib java jpeg libwww mad mikmod motif mozilla mpeg mpi mysql ncurses
nls opengl oss pam pdflib perl png python qt readline ruby ruby18 slang spell
src ssl stroke tcltk tcpd tetex tiff truetype xml2 xmms xv zlib"

==================================

[Comment 1 Ferris McCormick (RETIRED) 2004-08-10 12:44:23 UTC]

Assigned to greg k-h at his request.  Copied [e-mail].
(Notice that the example system is in fact running g-d-s-2.6.7-r11.)

[Comment 2 Greg Kroah-Hartman (RETIRED) 2004-08-12 14:39:36 UTC]

Fixed in g-d-s-2.6.7-r14