Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 599716 - net-libs/libssh2-9999 fails to build: Failed Patch: libssh2-1.8.0-libgcrypt-prefix.patch !
Summary: net-libs/libssh2-9999 fails to build: Failed Patch: libssh2-1.8.0-libgcrypt-p...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Netmon project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-11-14 16:35 UTC by Tomáš Mózes
Modified: 2016-11-15 05:57 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tomáš Mózes 2016-11-14 16:35:26 UTC
The patch went upstream so we can remove it:
https://github.com/libssh2/libssh2/commit/ced924b78a40126606797ef57a74066eb3b4b83f

Without the patch it compiles fine.


These are the packages that would be merged, in order:

[ebuild   R   *] net-libs/libssh2-9999::gentoo [9999::local] USE="zlib -gcrypt -libressl -static-libs {-test}" ABI_X86="(64) -32 (-x32)" 0 KiB

Total: 1 package (1 reinstall), Size of downloads: 0 KiB


>>> Verifying ebuild manifests

>>> Emerging (1 of 1) net-libs/libssh2-9999::gentoo
>>> Unpacking source...
 * Fetching https://github.com/libssh2/libssh2 ...
git fetch https://github.com/libssh2/libssh2 +HEAD:refs/git-r3/HEAD
git symbolic-ref refs/git-r3/net-libs/libssh2/0/__main__ refs/git-r3/HEAD
 * Checking out https://github.com/libssh2/libssh2 to /var/tmp/portage/net-libs/libssh2-9999/work/libssh2-9999 ...
git checkout --quiet refs/git-r3/HEAD
GIT update -->
   repository:               https://github.com/libssh2/libssh2
   at the commit:            028a0ba4ed435070beba153f643292d3cea2d88c
>>> Source unpacked in /var/tmp/portage/net-libs/libssh2-9999/work
>>> Preparing source in /var/tmp/portage/net-libs/libssh2-9999/work/libssh2-9999 ...
 * Applying libssh2-1.8.0-libgcrypt-prefix.patch ...

 * Failed Patch: libssh2-1.8.0-libgcrypt-prefix.patch !
 *  ( /usr/portage/net-libs/libssh2/files/libssh2-1.8.0-libgcrypt-prefix.patch )
 * 
 * Include in your bugreport the contents of:
 * 
 *   /var/tmp/portage/net-libs/libssh2-9999/temp/libssh2-1.8.0-libgcrypt-prefix.patch.out

 * ERROR: net-libs/libssh2-9999::gentoo failed (prepare phase):
 *   Failed Patch: libssh2-1.8.0-libgcrypt-prefix.patch!
 *
Comment 1 Jeroen Roovers (RETIRED) gentoo-dev 2016-11-14 19:50:56 UTC
(In reply to Tomáš Mózes from comment #0)
> The patch went upstream so we can remove it:

Why are we fixing live ebuild issues like this in the tree, anyway?

> Without the patch it compiles fine.

No, it doesn't. It magically fails or succeeds in picking a crypto library.
Comment 2 Tomáš Mózes 2016-11-15 05:57:14 UTC
(In reply to Jeroen Roovers from comment #1)
> (In reply to Tomáš Mózes from comment #0)
> > The patch went upstream so we can remove it:
> 
> Why are we fixing live ebuild issues like this in the tree, anyway?

How else would you handle it? Wait until it's merged upstream?

> 
> > Without the patch it compiles fine.
> 
> No, it doesn't. It magically fails or succeeds in picking a crypto library.

Well, I was just expressing my experience with it, it may fail somewhere else, I don't argue :)