599644 – sys-apps/portage: repoman could prevent commit of empty file

Bug 599644 - sys-apps/portage: repoman could prevent commit of empty file

Summary: sys-apps/portage: repoman could prevent commit of empty file

Status:	RESOLVED FIXED

Alias:	None

Product:	Portage Development
Classification:	Unclassified
Component:	Repoman (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	Portage team

URL:
Whiteboard:
Keywords:	InVCS

Depends on:
Blocks:

Reported:	2016-11-13 13:06 UTC by Agostino Sarubbo
Modified:	2017-06-16 01:35 UTC (History)
CC List:	1 user (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Agostino Sarubbo gentoo-dev

2016-11-13 13:06:47 UTC

See https://bugs.gentoo.org/show_bug.cgi?id=598774#c2

Comment 1 Mike Gilbert gentoo-dev

2016-11-13 14:12:25 UTC

That seems like quite an unlikely problem. Also, the referenced example was not committed via repoman anyway.

Comment 2 Ulrich Müller gentoo-dev

2017-06-14 20:48:06 UTC

I had committed the following some time ago (being unaware of this bug):
https://gitweb.gentoo.org/proj/portage.git/commit/?h=repoman&id=04e5f8dee2130901386f4f1b65328bbf0b8104c1

commit 04e5f8dee2130901386f4f1b65328bbf0b8104c1
Author: Ulrich Müller <ulm@gentoo.org>
Date:   Sun Feb 12 17:21:51 2017 +0100

    repoman: Check for empty files in filesdir.
    
    This checks for files with zero size in filesdir. The QA script at
    https://qa-reports.gentoo.org/output/find-binary-files.txt reports a
    couple of them which at least in part are blunders.


So can we consider this bug to be fixed?

Comment 3 Brian Dolbec (RETIRED) gentoo-dev

2017-06-16 01:35:15 UTC

Released in repoman-2.3.2