Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 599270 - dev-db/mariadb-10.1.19 snappy/lz4/lzo support never built
Summary: dev-db/mariadb-10.1.19 snappy/lz4/lzo support never built
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Linux MySQL bugs team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-11-09 10:01 UTC by Tomas Zvala
Modified: 2016-11-14 15:25 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Build log of original ebuild (mariadb-bad.log.xz,50.07 KB, application/x-xz)
2016-11-11 19:41 UTC, Tomas Zvala
Details
Build log of commented out ebuild (mariadb-good.log.xz,50.66 KB, application/x-xz)
2016-11-11 19:41 UTC, Tomas Zvala
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Tomas Zvala 2016-11-09 10:01:33 UTC
Current mariadb ebuilds (tested with 10.1.18 and 10.1.19) cause the lz4/lzo/snappy support to never be built.

Commenting out following definitions in ebuild causes the autodetection to kick in and support is built in just fine.  

        MYSQL_CMAKE_NATIVE_DEFINES+=(
            ...
            #-DWITH_INNODB_LZ4=$(usex innodb-lz4)
            #-DWITH_INNODB_LZO=$(usex innodb-lzo)
            #-DWITH_INNODB_SNAPPY=$(usex innodb-snappy)

I've tested this with cmake 3.3 and 3.5 with the same result.
Comment 1 Brian Evans (RETIRED) gentoo-dev 2016-11-11 15:29:00 UTC
Please attach a full build.log demonstrating the issue
Comment 2 Tomas Zvala 2016-11-11 19:41:20 UTC
Created attachment 453048 [details]
Build log of original ebuild
Comment 3 Tomas Zvala 2016-11-11 19:41:57 UTC
Created attachment 453064 [details]
Build log of commented out ebuild
Comment 4 Tomas Zvala 2016-11-11 19:44:33 UTC
I have attached two xzipped build.logs. One demonstrates the original behavior and the other one behavior after commenting out three aforementioned lines. Hope it helps.
Comment 5 Brian Evans (RETIRED) gentoo-dev 2016-11-11 19:52:03 UTC
Ok.. Now i see the issue.

"-DWITH_INNODB_LZ4=yes -DWITH_INNODB_LZO=yes -DWITH_INNODB_SNAPPY=yes"  is incorrect.

The ebuild should be fixed to be:

        MYSQL_CMAKE_NATIVE_DEFINES+=(
            ...
            -DWITH_INNODB_LZ4=$(usex innodb-lz4 ON OFF)
            -DWITH_INNODB_LZO=$(usex innodb-lzo ON OFF)
            -DWITH_INNODB_SNAPPY=$(usex innodb-snappy ON OFF)

Auto-detection is not acceptable as the dependencies can be off wildly.
Comment 6 Tomas Zvala 2016-11-11 19:57:56 UTC
Oh, don't get me wrong. I was not suggesting autodetection as a solution. It was a mere work-around for me. Sorry if that wasn't clear.

btw. I was looking at the ebuild and just got curious if it's the case with the rest of the plain usex flags. I'll test it and let you know.
Comment 7 Brian Evans (RETIRED) gentoo-dev 2016-11-14 15:25:26 UTC
Fixed with mariadb-10.1.19-r1