Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 599044 - sys-apps/openrc: Split tmpfiles.d support into a separate package
Summary: sys-apps/openrc: Split tmpfiles.d support into a separate package
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Hosted Projects
Classification: Unclassified
Component: OpenRC (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: OpenRC Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 599146
  Show dependency tree
 
Reported: 2016-11-06 07:58 UTC by Michał Górny
Modified: 2017-01-13 09:43 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2016-11-06 07:58:51 UTC
[19:54:19] <mgorny> guys, i was thinking: since openrc reimplements tmpfiles.d, maybe it'd be reasonable to split it into a separate package?
[19:54:57] <mgorny> i'm thinking of the systemd_tmpfiles_create function in systemd.eclass specifically
[19:55:21] <mgorny> if we modify it to support both systemd and openrc variants, it will still be limited to people having either installed
[19:55:43] <mgorny> (and therefore we will miss people that have neither)
[19:56:05] <mgorny> but if openrc-tmpfiles was a completely split package, i don't it much of harm to DEPEND on it everywhere
[03:48:01] <perfinion> that sounds reasonable
[03:48:19] <perfinion> the tmpfiles shell script is pretty simple so having it around isnt bad yeah

I don't think others have noticed that, so opening a bug instead. The idea is to have reliable tmpfiles.d support for ebuilds without having to implement fallbacks.
Comment 1 William Hubbs gentoo-dev 2016-11-07 16:29:50 UTC
(In reply to Michał Górny from comment #0)
> [19:54:19] <mgorny> guys, i was thinking: since openrc reimplements
> tmpfiles.d, maybe it'd be reasonable to split it into a separate package?

It might be. Longterm I want to rewrite this in C, because I think that would be better than the shell script we have.

Also, separating this functionality would mean there could be a separate eclass that handles tmpfiles.
Comment 2 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2016-11-07 16:35:15 UTC
(In reply to William Hubbs from comment #1)
> (In reply to Michał Górny from comment #0)
> > [19:54:19] <mgorny> guys, i was thinking: since openrc reimplements
> > tmpfiles.d, maybe it'd be reasonable to split it into a separate package?
> 
> It might be. Longterm I want to rewrite this in C, because I think that
> would be better than the shell script we have.

But could we split this before the rewrite, please? ;-)

> Also, separating this functionality would mean there could be a separate
> eclass that handles tmpfiles.

That was exactly my idea. Add a new eclass that would DEPEND on either of tmpfiles implementations and handle using them.
Comment 3 William Hubbs gentoo-dev 2016-11-07 23:12:22 UTC
Just a quick update to this bug, tmpfiles.sh uses checkpath which is an
openrc helper, so removing it from OpenRC will require that I
re-implement checkpath either in shell or C.
Comment 4 William Hubbs gentoo-dev 2016-11-08 23:10:13 UTC
There is now a live ebuild for https://github.com/openrc/tmpfiles in the
tree.
I will keep this open until openrc has been reworked to use it instead
of the internal tmpfiles.sh script.
Comment 5 William Hubbs gentoo-dev 2016-11-10 18:22:25 UTC
This has been renamed to https://github.com/openrc/opentmpfiles per a
suggestion from mgorny.

I will create a new live ebuild and remove the previous one. I don't
think a pkgmove is necessary since this isn't an officially released
package yet, but let me know if I'm wrong.
Comment 6 William Hubbs gentoo-dev 2016-12-20 18:11:03 UTC
https://github.com/openrc/openrc/commit/e0ac661

This is done in OpenRC 0.23.