Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 598938 - media-libs/tiff-4.0.6: fax2tiff passing pointer to int instead of int
Summary: media-libs/tiff-4.0.6: fax2tiff passing pointer to int instead of int
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Graphics Project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-11-04 14:45 UTC by Jörg Ahrens
Modified: 2017-03-31 03:43 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
patch to fix the problem in fax2tiff (tiff-4.0.6_fax2tiff.patch,711 bytes, patch)
2016-11-04 14:45 UTC, Jörg Ahrens 		Details | Diff
a diff that patch will accept (tiff-4.0.6_fax2tiff.patch,800 bytes, patch)
2016-11-20 02:34 UTC, Jörg Ahrens 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jörg Ahrens 2016-11-04 14:45:56 UTC 
Created attachment 452378 [details, diff]
patch to fix the problem in fax2tiff

fax2tiff.c passes int as pointer:

TIFFSetClientdata(faxTIFF, (thandle_t) &client_data);

the library expects int or file handle(win32) here (see also: code in tiff-3…)

Result: fax2tiff cant't read input file.

This is an upstream bug.

pls see attached patch.
Comment 1 Jonas Stein gentoo-dev 2016-11-08 18:42:48 UTC 
Jörg, thank you for the patch.
The ideal way would be to have the patch in the upstream source (too).
Could you -if not done yet- send the patch upstream, please?
Best, Jonas
Comment 2 Jörg Ahrens 2016-11-20 02:33:06 UTC 
I sent my patch upstream today. I also found that patch doesn't like my diff so I will attach a better one.
Comment 3 Jörg Ahrens 2016-11-20 02:34:28 UTC 
Created attachment 453794 [details, diff]
a diff that patch will accept
Comment 4 SpanKY gentoo-dev 2017-03-31 03:43:47 UTC 
looks like it was fixed after the 4.0.7 release.  i've cherry picked it back into our 4.0.7-r1 now:
https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7ec3d94b9cb12fb65a0274021d154b9b0d7977c8