Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 598862 - dev-ruby/rspec-support-3.5.0 fails tests when dev-vcs/git is missing
Summary: dev-ruby/rspec-support-3.5.0 fails tests when dev-vcs/git is missing
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Ruby Team
URL:
Whiteboard:
Keywords: TESTFAILURE
Depends on:
Blocks:
 
Reported: 2016-11-03 13:45 UTC by Michael Palimaka (kensington)
Modified: 2017-04-16 06:18 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,7.84 KB, text/plain)
2016-11-03 13:45 UTC, Michael Palimaka (kensington)
Details
Patches (rspec-support-3.5.0_598862.patch,1.69 KB, patch)
2017-04-16 05:13 UTC, Abhijith PA
Details | Diff
Patch for ebuild (new.patch,1.17 KB, patch)
2017-04-16 05:14 UTC, Abhijith PA
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Palimaka (kensington) gentoo-dev 2016-11-03 13:45:47 UTC
Created attachment 452254 [details]
build.log

Failures:

  1) RSpec::Support behaves like library wide checks has no malformed whitespace
     Failure/Error:
       `git ls-files -z`.split("\x0").each do |filename|
         error_messages << check_for_tab_characters(filename)
         error_messages << check_for_extra_spaces(filename)
       end

     Errno::ENOENT:
       No such file or directory - git
Comment 1 Abhijith PA 2017-04-14 07:42:00 UTC
For testing ,it also need dev-ruby/thread_order , right .
but it is not specified in in the depends .
Comment 2 Abhijith PA 2017-04-14 07:44:10 UTC
I am working on it .
Comment 3 Abhijith PA 2017-04-16 05:13:00 UTC
Created attachment 470106 [details, diff]
Patches

This patch solves the test failure issue.
Comment 4 Abhijith PA 2017-04-16 05:14:03 UTC
Created attachment 470108 [details, diff]
Patch for ebuild

This patch is for ebuild, 

Please review and merge.
Comment 5 Hans de Graaff gentoo-dev Security 2017-04-16 06:18:35 UTC
Thanks for the patches. I have used them to fix the issues with the ebuilds.

A few notes:

As far as I know it is bad practice to update the eapi of an existing ebuild without a revision bump, so I left this out. We'll update to new eapis on version bumps. I thought we still needed to do some work to ruby-fakegem.eclass to support EAPI=6, but this already works out of the box. Thanks for testing that.

The thread_order dependency should be within the test? () part of the dependency, since it is only required for the tests.

We prefer to use sed in the ebuild to patch these kinds of changes, because it is lower maintenance. Any problems with the seds show up during test time, or are harmless. We do prefer patches to change code that gets installed.