Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 59787 - libgnome only uses comment field in /etc/passwd to save username in gnome-games
Summary: libgnome only uses comment field in /etc/passwd to save username in gnome-games
Status: RESOLVED UPSTREAM
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] GNOME (show other bugs)
Hardware: x86 Linux
: Lowest minor (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-08-08 10:17 UTC by Rémi Cardona (RETIRED)
Modified: 2005-01-28 19:05 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Rémi Cardona (RETIRED) gentoo-dev 2004-08-08 10:17:24 UTC
All the high score in Mines, Same and Mahjong (possibly all other as well) save scores properly but the user name is always wrong since gnome 2.6.0 All the scores belong to the user "unknown".
(not that big a deal:) but still looks like a bug)

Reproducible: Always
Steps to Reproduce:
1. play a gnome game (eg gnome mines)
2. win the game (very important!)
3. go see the high scores



Expected Results:  
My user name should have been in the chart

I have this bug on three boxes all running gnome 2.6+ (various versions) on
various 2.6 kernels.
I have noticed this bug in January or February but it hasn't been fixed since.
Comment 1 Joel Armstrong 2004-08-08 12:50:30 UTC
This happens to me, also on Gnometris.
Comment 2 foser (RETIRED) gentoo-dev 2004-08-09 03:22:49 UTC
well could you maybe find out why ?
Comment 3 Rémi Cardona (RETIRED) gentoo-dev 2004-08-09 12:46:26 UTC
I'm currently rebuilding gnome-games in my ~/ to see if I get the same problems.

I specified CFLAGS="-g -Wall" during the ./configure. I found that there's a libgnome call to handle all the high score so I'm afraid the problem is more likely to be in there.
Comment 4 Rémi Cardona (RETIRED) gentoo-dev 2004-08-09 13:25:22 UTC
Here is the call made in gnome-games-2.6.2/same-gnome/same-gnome.c:326

http://developer.gnome.org/doc/API/2.0/libgnome/libgnome-gnome-score.html#gnome-score-log

It's directly handled by libgnome. That's as far as I could go tonight. If anyone cares to help me find what's beneath libgnome (sounds scary :) ), I'd appreciate it.
Comment 5 Mike Gardiner (RETIRED) gentoo-dev 2004-08-11 03:43:00 UTC
Mine lists my name just fine. Have you set your real name under your user account correctly? (usermod -c "My Name" <username>)
Comment 6 Rémi Cardona (RETIRED) gentoo-dev 2004-08-11 13:46:55 UTC
Yes it fixed it, but you can't expect everyone to actually put their name in the Comment field. (It doesn't say "real name" but "comment") Moreover it requires root privileges to do it.

Shouldn't it default to the "basic" username if the comment field is empty? It used to work that way in gnome 2.4. Looks like an ultra minor regression :)

I changed the summary from 'gnome games save scores using user "unknown"' to 'libgnome only uses comment field in /etc/passwd to save username in gnome-games'. Perhaps it's a behavior that could be changed.

R
Comment 7 Rémi Cardona (RETIRED) gentoo-dev 2004-08-11 13:46:55 UTC
Yes it fixed it, but you can't expect everyone to actually put their name in the Comment field. (It doesn't say "real name" but "comment") Moreover it requires root privileges to do it.

Shouldn't it default to the "basic" username if the comment field is empty? It used to work that way in gnome 2.4. Looks like an ultra minor regression :)

I changed the summary from 'gnome games save scores using user "unknown"' to 'libgnome only uses comment field in /etc/passwd to save username in gnome-games'. Perhaps it's a behavior that could be changed.

Rémi
Comment 8 Richard Hoelscher 2004-09-13 19:24:38 UTC
Sorry for not noticing this earlier, gentoo's bugzilla doesn't have a great interface for tracking gnome-games bugs....

The odd part of this bug is it's been here since '99, but most people didn't notice it (or say something about it) until some time last month. It'll be handled upstream, either in libgnome during GNOME-2.9, or when all of the code for high scores gets moved into gnome-games, also probably during GNOME-2.9 development.

Yes, it is scary. Currently, libgnome's scores returns an untranslated string when it doesn't find a Real Name for the user: "Unknown"

You don't need root privs, just use chfn (...assuming this works fine in gentoo).

http://bugs.gnome.org/show_bug.cgi?id=149204
http://bugs.gnome.org/show_bug.cgi?id=149270
Comment 9 Rémi Cardona (RETIRED) gentoo-dev 2004-09-13 23:22:38 UTC
Thanks Richard for pointing those two bug reports out.

In the mean time, couldn't we include the patch in portage for gnome-games-2.6.2-r1 or something like that? The patch is less than 1Ko

R
Comment 10 Rémi Cardona (RETIRED) gentoo-dev 2004-09-13 23:22:38 UTC
Thanks Richard for pointing those two bug reports out.

In the mean time, couldn't we include the patch in portage for gnome-games-2.6.2-r1 or something like that? The patch is less than 1Ko

Rémi
Comment 11 Richard Hoelscher 2005-01-28 18:56:41 UTC
This will be fixed through libgnome for GNOME 2.10
Comment 12 Joe McCann (RETIRED) gentoo-dev 2005-01-28 19:05:00 UTC
yep, sounds good