Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 597448 - dev-lang/php: remove workaround for heimdal support
Summary: dev-lang/php: remove workaround for heimdal support
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: PHP Bugs
URL: https://github.com/php/php-src/pull/2147
Whiteboard:
Keywords: UPSTREAM
Depends on:
Blocks: 597450
  Show dependency tree
 
Reported: 2016-10-18 14:30 UTC by Michael Orlitzky
Modified: 2017-01-20 16:57 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Orlitzky gentoo-dev 2016-10-18 14:30:04 UTC
Our PHP ebuilds support both the MIT and Heimdal implementations of Kerberos through virtual/krb5. We have some dark magic to allow this,

  src_prepare() {
    ....
    # Patch PHP to support heimdal instead of mit-krb5
    if has_version "app-crypt/heimdal" ; then
      sed -e 's|gssapi_krb5|gssapi|g' -i acinclude.m4 \
        || die "Failed to fix heimdal libname"
      sed -e 's|PHP_ADD_LIBRARY(k5crypto, 1, $1)||g' -i acinclude.m4 \
        || die "Failed to fix heimdal crypt library reference"
    fi

but upstream should support it out-of-the-box. The fact that it doesn't is just a bug, that I've fixed in $URL and reported as PHP bug #73214. Once that fix (or something like it) goes in, we can remove the acinclude.m4 hacks.
Comment 1 Michael Orlitzky gentoo-dev 2016-11-30 15:46:15 UTC
This fix was just merged into the master and 7.0 branches, so the next 7.0.x release will probably contain it.
Comment 2 Michael Orlitzky gentoo-dev 2016-12-03 03:19:56 UTC
Done in the new v7.1.0.
Comment 3 Michael Orlitzky gentoo-dev 2017-01-20 16:57:14 UTC
Fixed in 7.0.15, too. Not gonna happen in 5.6.x so this is done.