Bug 59743 – log4cxx compile fails on errno

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Benjamin Collins 2004-08-07 19:35:44 UTC]

An unwise #define causes errno.h to not be included when compiling on linux.  Patch is attached.

Reproducible: Always
Steps to Reproduce:
1.
2.
3.

[Comment 1 Benjamin Collins 2004-08-07 19:38:19 UTC]

Created attachment 36997 [details, diff]
patch for log4cxx-0.9.5

~/src/filewatchdog.cpp

[Comment 2 Benjamin Collins 2004-08-07 19:42:17 UTC]

Comment on attachment 36997 [details, diff]
patch for log4cxx-0.9.5

>--- filewatchdog.cpp.orig	2004-08-07 21:36:34.987676584 -0500
>+++ filewatchdog.cpp	2004-08-07 21:36:41.562677032 -0500
>@@ -17,10 +17,7 @@
> #include <log4cxx/helpers/filewatchdog.h>
> #include <log4cxx/helpers/loglog.h>
> #include <sys/stat.h>
>-
>-#ifdef WIN32
>-#include <errno.h>
>+#include <cerrno>
>-#endif
> 
> using namespace log4cxx;
> using namespace log4cxx::helpers;

[Comment 3 Benjamin Collins 2004-08-07 20:18:51 UTC]

Created attachment 36998 [details, diff]
patch #2 for log4cxx-0.9.5

[Comment 4 Bjarke Istrup Pedersen (RETIRED) 2004-08-07 23:02:10 UTC]

Compiles fine for me when using changed patch 1, and patch 2.
I have combined them into one, and corrected the path (added src/ before the filenames).
This obsoletes patch 1 and 2.

[Comment 5 Bjarke Istrup Pedersen (RETIRED) 2004-08-07 23:02:54 UTC]

Created attachment 37000 [details, diff]
combined patch

[Comment 6 Aaron Walker (RETIRED) 2004-12-26 05:54:54 UTC]

Do you still run into this problem with 0.9.7?

[Comment 7 Aaron Walker (RETIRED) 2005-01-06 05:48:49 UTC]

Fixed. Thanks guys.