Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 597292 - sys-power/apcupsd-3.14.14: Enable MODBUS support over usb
Summary: sys-power/apcupsd-3.14.14: Enable MODBUS support over usb
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Kristian Fiskerstrand (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-16 15:19 UTC by John Einar Reitan
Modified: 2016-11-23 20:56 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
ebuild change to control MODBUS support in apcupsd (modbus.diff,1.05 KB, patch)
2016-10-16 15:19 UTC, John Einar Reitan
Details | Diff
ebuild change to control MODBUS support in apcupsd v2 (modbus.diff,1.05 KB, patch)
2016-10-16 16:11 UTC, John Einar Reitan
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description John Einar Reitan 2016-10-16 15:19:21 UTC
Created attachment 450402 [details, diff]
ebuild change to control MODBUS support in apcupsd

MODBUS is the protocol used by newer APC UPSes and is needed to get usable output. apcupsd has supported MODBUS over RS232 since 3.14.13 and USB since 3.14.14.
By default MODBUS is only enabled over RS232 and disabled over USB.
--enable-modbus-usb is needed to enable MODBUS support over USB while --disable-modbus is needed to disable it over RS232 and USB.
MODBUS over USB needs dev-libs/libusb-compat.

Attached is a patch against the sys-power/apcupsd-3.14.14 ebuild to control MODBUS support.
Comment 1 John Einar Reitan 2016-10-16 16:11:19 UTC
Created attachment 450420 [details, diff]
ebuild change to control MODBUS support in apcupsd v2

Previous diff was reversed....
Comment 2 Kristian Fiskerstrand (RETIRED) gentoo-dev 2016-11-18 23:41:10 UTC
[That name sounds suspiciously Norwegian?]

Thanks for the patch. Applied in https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=805b76407ea2d40e78fd5c3078b2429761c9f7d5

Would you be interested in being a proxied maintainer for this package? Some more info on it available at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers
Comment 3 John Einar Reitan 2016-11-23 11:25:52 UTC
(In reply to Kristian Fiskerstrand from comment #2)
> [That name sounds suspiciously Norwegian?]

Jupp, a Norwegian up in Trondheim. Heisann!

> Thanks for the patch. Applied in
> https://gitweb.gentoo.org/repo/gentoo.git/commit/
> ?id=805b76407ea2d40e78fd5c3078b2429761c9f7d5

Thanks, have now switched from by overlay to the offical gentoo repo for apcupsd and confirmed that my modbus based UPS still works (and the non-modbus based one works too).

> Would you be interested in being a proxied maintainer for this package? Some
> more info on it available at
> https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers

Sounds interesting. An easy start into doing more for Gentoo.
Comment 4 Kristian Fiskerstrand (RETIRED) gentoo-dev 2016-11-23 20:56:16 UTC
(In reply to John Einar Reitan from comment #3)
> (In reply to Kristian Fiskerstrand from comment #2)
> > [That name sounds suspiciously Norwegian?]
> 
> Jupp, a Norwegian up in Trondheim. Heisann!

Heisann. Oslo here :) 

> 
> > Thanks for the patch. Applied in
> > https://gitweb.gentoo.org/repo/gentoo.git/commit/
> > ?id=805b76407ea2d40e78fd5c3078b2429761c9f7d5
> 
> Thanks, have now switched from by overlay to the offical gentoo repo for
> apcupsd and confirmed that my modbus based UPS still works (and the
> non-modbus based one works too).
> 
> > Would you be interested in being a proxied maintainer for this package? Some
> > more info on it available at
> > https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers
> 
> Sounds interesting. An easy start into doing more for Gentoo.

I've added you to metadata.xml so you will be assigned new issues for this package with myself CCed so I can commit for you. Feel free to email me or contact me on IRC (FreeNode, nick K_F) you'll find me in #gentoo-dev , #gentoo-proxy-maint etc, the latter of which is a good place to ask generic ebuild questions.

PS. Incidentally there will likely be a few presentations by Gentoo developers arranged via NUUG this year. In Oslo, but also streamed and recorded. So stay tuned :)