With bash-4.4-r1 git-stash is very noisy. Maybe it also does something bad/wrong, I haven't looked into it. eroen@occam /usr/local/portage $ git stash -u /usr/libexec/git-core/git-stash: line 38: warning: command substitution: ignored null byte in input ... snip ... /usr/libexec/git-core/git-stash: line 38: warning: command substitution: ignored null byte in input Saved working directory and index state WIP on master: 503f638 drop obsolete packages HEAD is now at 503f638 drop obsolete packages eroen@occam /usr/local/portage $
occam ~ # emerge --info git bash Portage 2.3.2 (python 2.7.12-final-0, hardened/linux/amd64, gcc-6.2.0, glibc-2.23-r2, 4.7.6-hardened-o0 x86_64) ================================================================= System Settings ================================================================= System uname: Linux-4.7.6-hardened-o0-x86_64-Intel-R-_Core-TM-_i5-2520M_CPU_@_2.50GHz-with-gentoo-2.3 KiB Mem: 8000476 total, 482772 free KiB Swap: 16777212 total, 16576716 free Timestamp of repository gentoo: Fri, 14 Oct 2016 16:00:01 +0000 sh bash 4.4-r1 ld GNU ld (Gentoo 2.26.1 p1.0) 2.26.1 ccache version 3.2.7 [disabled] app-shells/bash: 4.4-r1::gentoo dev-java/java-config: 2.2.0-r3::gentoo dev-lang/perl: 5.24.0-r1::gentoo dev-lang/python: 2.7.12::gentoo, 3.4.5::gentoo, 3.5.2::gentoo dev-util/ccache: 3.2.7::gentoo dev-util/cmake: 3.6.2::gentoo dev-util/pkgconfig: 0.29.1::gentoo sys-apps/baselayout: 2.3::gentoo sys-apps/openrc: 0.22.2::gentoo sys-apps/sandbox: 2.10-r2::gentoo sys-devel/autoconf: 2.69-r2::gentoo sys-devel/automake: 1.12.6-r1::gentoo, 1.14.1-r1::gentoo, 1.15-r2::gentoo sys-devel/binutils: 2.26.1::gentoo sys-devel/gcc: 4.9.3::gentoo, 5.3.0::gentoo, 5.4.0::gentoo, 6.2.0-r1::gentoo sys-devel/gcc-config: 1.8-r1::gentoo sys-devel/libtool: 2.4.6-r2::gentoo sys-devel/make: 4.2.1::gentoo sys-kernel/linux-headers: 4.7::gentoo (virtual/os-headers) sys-libs/glibc: 2.23-r2::gentoo Repositories: gentoo location: /usr/portage sync-type: rsync sync-uri: rsync://rsync.gentoo.org/gentoo-portage priority: -1000 sync-rsync-extra-opts: --exclude ChangeLog* --exclude /metadata/cache/ --stats --delay-updates -c eroen location: /usr/local/portage masters: gentoo priority: 0 wine-a-holics location: /home/eroen/repos/wine-overlay masters: gentoo priority: 1 enlightenment location: /var/lib/layman/enlightenment masters: gentoo priority: 50 flora location: /var/lib/layman/flora masters: gentoo priority: 50 gamerlay location: /var/lib/layman/gamerlay masters: gentoo priority: 50 glc location: /var/lib/layman/glc masters: gentoo priority: 50 hardened-development location: /var/lib/layman/hardened-development masters: gentoo priority: 50 haskell location: /var/lib/layman/haskell masters: gentoo priority: 50 hasufell location: /var/lib/layman/hasufell masters: gentoo priority: 50 java location: /var/lib/layman/java masters: gentoo priority: 50 laurentb location: /var/lib/layman/laurentb masters: gentoo priority: 50 roslin location: /var/lib/layman/roslin masters: gentoo priority: 50 science location: /var/lib/layman/science masters: gentoo priority: 50 stuff location: /var/lib/layman/stuff masters: gentoo priority: 50 sunrise location: /var/lib/layman/sunrise masters: gentoo priority: 50 toolchain location: /var/lib/layman/toolchain masters: gentoo priority: 50 v-fox location: /var/lib/layman/v-fox masters: gentoo priority: 50 wine-overlay location: /var/lib/layman/wine-overlay masters: gentoo priority: 50 ACCEPT_KEYWORDS="amd64 ~amd64" ACCEPT_LICENSE="*" CBUILD="x86_64-pc-linux-gnu" CFLAGS="-march=corei7-avx -O3 -pipe -flto -ffat-lto-objects -fuse-linker-plugin -floop-interchange -floop-strip-mine -floop-block -fgraphite-identity" CHOST="x86_64-pc-linux-gnu" CONFIG_PROTECT="/etc /usr/share/config /usr/share/easy-rsa /usr/share/gnupg/qualified.txt" CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c" CXXFLAGS="-march=corei7-avx -O3 -pipe -flto -ffat-lto-objects -fuse-linker-plugin -floop-interchange -floop-strip-mine -floop-block -fgraphite-identity" DISTDIR="/var/distfiles" EMERGE_DEFAULT_OPTS="--jobs=4 --autounmask --quiet-build --nospinner --verbose-conflicts --verbose-slot-rebuilds" FCFLAGS="-O2 -pipe" FEATURES="assume-digests binpkg-logs binpkg-multi-instance cgroup collision-protect compressdebug config-protect-if-modified distlocks ebuild-locks fixlafiles ipc-sandbox merge-sync network-sandbox news parallel-fetch parallel-install preserve-libs protect-owned sandbox sfperms split-log strict test unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr" FFLAGS="-O2 -pipe" GENTOO_MIRRORS="" LANG="en_GB.utf8" LDFLAGS="-Wl,-O1 -Wl,--as-needed -Wl,--hash-style=gnu" MAKEOPTS="-j4 -l10" PKGDIR="/var/packages" PORTAGE_COMPRESS="xz" PORTAGE_COMPRESS_FLAGS="-9" PORTAGE_CONFIGROOT="/" PORTAGE_RSYNC_EXTRA_OPTS="--exclude ChangeLog* --exclude /metadata/cache/ --stats --delay-updates -c" PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git" PORTAGE_TMPDIR="/var/tmp" USE="X a52 aac acl alsa amd64 apng audio audiofile avresample avx bash-completion bdf berkdb bluray bzip2 cairo caps cb cdda cdparanoia cdr cjk cli corefonts cracklib crypt cups curl cxx ddate declarative detex device-mapper dga dia djvu dmapi dri dts dvd dvi2tty dvipdfm ebook egl exif fam ffmpeg fftw fits flac fontconfig g3dvl gallium gbm gcrypt gdbm gif gimp git glamor glib glibc-omitfp gmp gnuplot gnutls gold gpm graphics graphviz gs gstreamer gtk gtk3 hardened highlight hscolour iconv icu id3tag idn imagemagick imlib inotify iproute2 ipv6 jbig jpeg jpeg2k jpg json justify kde kde4 kpathsea latex lcms libffi libssh2 libv4l luatex lvm lvm2 lzma lzo man metric mikmod mkv mms mmx mmxext mng modules mp3 mpeg mpg123 multilib multimedia musepack ncurses netlink nptl nut ocr odbc offensive ogg opengl openmp openvg optimization optimized-qmake opus orc pam pango pax_kernel pcre pdf pgf phonon pie png postscript private-headers pstricks pth publishers python3 qt3support qt4 raw readline samba sbsms scanner science sdl seccomp session smp sna sndfile speex spell sqlite sse sse2 sse3 sse4 sse41 sse4_1 sse4_2 ssh ssl ssp ssse3 svg t1lib tcpd tesseract theora threads tiff tls truetype udev unicode urandom usb v4l v4l2 vaapi video vorbis vpx webp wmf x264 xanim xattr xcb xcomposite xetex xfs xft xinerama xkb xml xmlpatterns xorg xosd xpm xrandr xtpax xv xvid xvmc xz zlib zsh-completion" ABI_X86="32 64" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump author" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="mmx sse sse2 avx sse3 ssse3 sse4_1 aes avx mmxext popcnt sse3 sse4_1 sse4_2 ssse3" CURL_SSL="openssl" DRACUT_MODULES="btrfs caps cifs crypt crypt-gpg dash iscsi lvm nfs ssh-client syslog" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ublox ubx" GRUB_PLATFORMS="efi-64" INPUT_DEVICES="mouse keyboard evdev synaptics wacom" KERNEL="linux" L10N="en en-US en-GB eng jbo no nb nn no-NO nb-NO nn-NO nor" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LINGUAS="en gb us en_US en_GB eng jbo no nb nn no_NO nb_NO nn_NO nor" OFFICE_IMPLEMENTATION="libreoffice" PYTHON_SINGLE_TARGET="python2_7" PYTHON_TARGETS="python2_7 python3_4 python3_5" QEMU_SOFTMMU_TARGETS="x86_64 i386" RUBY_TARGETS="ruby22" SANE_BACKENDS="plustek" USERLAND="GNU" VIDEO_CARDS="intel i965 ilo" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account" USE_PYTHON="2.7 3.3 3.4" Unset: CC, CPPFLAGS, CTARGET, CXX, INSTALL_MASK, LC_ALL, PORTAGE_BUNZIP2_COMMAND ================================================================= Package Settings ================================================================= dev-vcs/git-2.10.1::gentoo was built with the following: USE="blksha1 curl gpg highlight iconv pcre perl python test threads webdav -cgi -cvs -doc -emacs -gnome-keyring -gtk -libressl -mediawiki -mediawiki-experimental -nls (-ppcsha1) -subversion -tk -xinetd" ABI_X86="64" LINGUAS="-bg -ca -de -fr -is -it -ko -pt_PT -ru -sv -vi -zh_CN" PYTHON_TARGETS="python2_7" app-shells/bash-4.4-r1::gentoo was built with the following: USE="net (readline) -afs -bashlogger -examples -mem-scramble -nls -plugins -vanilla" ABI_X86="64" occam ~ # emerge -pvq =dev-vcs/git-2.10.1 =app-shells/bash-4.4-r1 [ebuild R ] app-shells/bash-4.4-r1 USE="net (readline) -afs -bashlogger -examples -mem-scramble -nls -plugins -vanilla" [ebuild R ] dev-vcs/git-2.10.1 USE="blksha1 curl gpg highlight iconv pcre perl python {test} threads webdav -cgi -cvs -doc -emacs -gnome-keyring -gtk -libressl -mediawiki -mediawiki-experimental -nls (-ppcsha1) -subversion -tk -xinetd" LINGUAS="-bg -ca -de -fr -is -it -ko -pt_PT -ru -sv -vi -zh_CN" PYTHON_TARGETS="python2_7"
Note that, as of 4.4_p2, bash will emit a warning no more than once for each command substitution, rather than for every single NUL byte encountered in a substitution. I've taken a look at the offending function in git-stash, which is a sh(1) script: no_changes () { git diff-index --quiet --cached HEAD --ignore-submodules -- && git diff-files --quiet --ignore-submodules && (test -z "$untracked" || test -z "$(untracked_files)") } I recommend that it be written as follows: no_changes () { git diff-index --quiet --cached HEAD --ignore-submodules -- && git diff-files --quiet --ignore-submodules && { test -z "$untracked" || ! untracked_files | grep -q .; } } The reasons are twofold. Firstly, this use of grep won't trigger any warnings in bash, because command substitution is avoided. Indeed, it addresses the very problem that bash is warning of - that NUL bytes will not be counted. Further, I would consider it safer on the basis that the shell is not forced to perform a potentially costly (in memory) expansion, depending on the length of the output of the untracked_files command. Secondly, the latter two tests are combined into a single compound command by way of parentheses. However, this is a silly way of doing it because it results in a subshell being spawned - something that simply isn't necessary here. Instead, the command list can be surrounded by curly braces.
Same problem here. ~ $ emerge --info git bash Portage 2.3.3 (python 2.7.12-final-0, default/linux/amd64/13.0/desktop/plasma, gcc-5.4.0, glibc-2.23-r3, 4.4.39-gentoo x86_64) ================================================================= System Settings ================================================================= System uname: Linux-4.4.39-gentoo-x86_64-Intel-R-_Core-TM-_i7-2600K_CPU_@_3.40GHz-with-gentoo-2.3 KiB Mem: 16359004 total, 1685644 free KiB Swap: 33791996 total, 33785584 free Timestamp of repository gentoo: Tue, 24 Jan 2017 12:30:01 +0000 sh bash 4.4_p11 ld GNU ld (Gentoo 2.27 p1.0) 2.27 app-shells/bash: 4.4_p11::gentoo dev-java/java-config: 2.2.0-r3::gentoo dev-lang/perl: 5.24.1_rc4::gentoo dev-lang/python: 2.7.12::gentoo, 3.5.2::gentoo dev-util/cmake: 3.7.2::gentoo dev-util/pkgconfig: 0.29.1::gentoo sys-apps/baselayout: 2.3::gentoo sys-apps/openrc: 0.23.1::gentoo sys-apps/sandbox: 2.10-r3::gentoo sys-devel/autoconf: 2.13::gentoo, 2.69-r2::gentoo sys-devel/automake: 1.13.4-r1::gentoo, 1.14.1-r1::gentoo, 1.15-r2::gentoo sys-devel/binutils: 2.27::gentoo sys-devel/gcc: 4.9.3::gentoo, 5.4.0-r2::gentoo sys-devel/gcc-config: 1.8-r1::gentoo sys-devel/libtool: 2.4.6-r2::gentoo sys-devel/make: 4.2.1::gentoo sys-kernel/linux-headers: 4.9::gentoo (virtual/os-headers) sys-libs/glibc: 2.23-r3::gentoo Repositories: gentoo location: /usr/portage sync-type: rsync sync-uri: rsync://rsync.gentoo.org/gentoo-portage priority: -1000 Biglair location: /usr/local/portage/biglair masters: gentoo kde location: /var/lib/layman/kde sync-type: laymansync sync-uri: git://anongit.gentoo.org/proj/kde.git masters: gentoo priority: 50 mooyooma location: /var/lib/layman/mooyooma sync-type: laymansync sync-uri: https://gitlab.com/mooyooma-overlay/mooyooma-overlay.git masters: gentoo priority: 50 pg_overlay location: /var/lib/layman/pg_overlay sync-type: laymansync sync-uri: https://github.com/perfect7gentleman/pg_overlay.git masters: gentoo priority: 50 steam-overlay location: /var/lib/layman/steam-overlay sync-type: laymansync sync-uri: git://github.com/anyc/steam-overlay.git masters: gentoo priority: 50 x11 location: /var/lib/layman/x11 sync-type: laymansync sync-uri: git://anongit.gentoo.org/proj/x11 masters: gentoo priority: 50 ACCEPT_KEYWORDS="amd64 ~amd64" ACCEPT_LICENSE="* -@EULA" CBUILD="x86_64-pc-linux-gnu" CFLAGS="-O2 -pipe -march=native -mtune=native" CHOST="x86_64-pc-linux-gnu" CONFIG_PROTECT="/etc /usr/share/config /usr/share/gnupg/qualified.txt" CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/php/apache2-php5.6/ext-active/ /etc/php/apache2-php7.0/ext-active/ /etc/php/cgi-php5.6/ext-active/ /etc/php/cgi-php7.0/ext-active/ /etc/php/cli-php5.6/ext-active/ /etc/php/cli-php7.0/ext-active/ /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo" CXXFLAGS="-O2 -pipe -march=native -mtune=native" DISTDIR="/usr/portage/distfiles" EMERGE_DEFAULT_OPTS="--quiet-build=y --backtrack=30 --with-bdeps=y --keep-going" FCFLAGS="-O2 -pipe" FEATURES="assume-digests binpkg-logs config-protect-if-modified distlocks ebuild-locks fixlafiles merge-sync news parallel-fetch preserve-libs protect-owned sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr" FFLAGS="-O2 -pipe" GENTOO_MIRRORS="http://distfiles.gentoo.org" LANG="en_US.utf8" LDFLAGS="-Wl,-O1 -Wl,--as-needed" MAKEOPTS="--jobs=9" PKGDIR="/usr/portage/packages" PORTAGE_CONFIGROOT="/" PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git" PORTAGE_TMPDIR="/var/tmp" USE="X a52 aac acl acpi alsa amd64 berkdb bzip2 cairo cjk cli consolekit cracklib crypt cups cxx dbus declarative dri dts emboss encode exif fam ffmpeg firefox flac fortran gdbm gif git glamor gpm gtk iconv icu introspection ipv6 java javascript jpeg kde kerberos kipi lcms ldap libnotify mad mng modules mp3 mp4 mpeg mtp multilib ncurses networkmanager nls nptl offensive ogg opengl openmp pam pango pcre pdf phonon php plasma png policykit ppds python qml qt3support qt4 qt5 readline sdl seccomp semantic-desktop session spell sqlite ssl startup-notification svg tcpd threads tiff truetype udev udisks unicode upower usb vdpau vorbis widgets wxwidgets x264 xattr xcb xcomposite xinerama xml xscreensaver xv xvid zlib" ABI_X86="64 32" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump author" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="mmx sse sse2 mmxext" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="libinput keyboard mouse" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LINGUAS="en" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php5-6 php7-0" PYTHON_SINGLE_TARGET="python2_7" PYTHON_TARGETS="python2_7 python3_5" RUBY_TARGETS="ruby21 ruby23 ruby24" USERLAND="GNU" VIDEO_CARDS="nvidia" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account" Unset: CC, CPPFLAGS, CTARGET, CXX, INSTALL_MASK, LC_ALL, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, USE_PYTHON ================================================================= Package Settings ================================================================= dev-vcs/git-2.11.0::gentoo was built with the following: USE="blksha1 curl gpg gtk iconv nls pcre perl python threads webdav -cgi -cvs -doc -emacs -gnome-keyring -highlight -libressl -mediawiki -mediawiki-experimental (-ppcsha1) -subversion -test -tk -xinetd" ABI_X86="64" LINGUAS="-bg -ca -de -fr -is -it -ko -pt_PT -ru -sv -vi -zh_CN" PYTHON_TARGETS="python2_7" app-shells/bash-4.4_p11::gentoo was built with the following: USE="net nls (readline) -afs -bashlogger -examples -mem-scramble -plugins" ABI_X86="64"
~/code/XXXXXXXX/XXXXXX/XXXXXXXXXX $ git stash save -a -u /usr/libexec/git-core/git-stash: line 38: warning: command substitution: ignored null byte in input /usr/libexec/git-core/git-stash: line 38: warning: command substitution: ignored null byte in input Saved working directory and index state WIP on issue/XXX-XXXXXX: XXXX XXXXXX HEAD is now at XXXXXXX XXXXXXXXXX
No longer an issue with latest git.
