Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 596746 - net-nntp/sabnzbd: Rework init script
Summary: net-nntp/sabnzbd: Rework init script
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: Normal normal (vote)
Assignee: Justin Bronder (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-10 08:58 UTC by Michał Kępień
Modified: 2016-10-28 13:00 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Suggested replacement init script (sabnzbd.initd,1.34 KB, text/plain)
2016-10-10 08:58 UTC, Michał Kępień
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Kępień 2016-10-10 08:58:42 UTC
Created attachment 449730 [details]
Suggested replacement init script

Greetings,

Upon encountering an IPv6-related issue with the init script provided by
this ebuild, I took the liberty of rewriting it virtually from scratch.
I created a pull request for it [1], but then I was informed that the
maintainer does not have a GitHub account and thus I should create a bug
instead, so here I am.

In the pull request, I added a lot of line comments to both the original
contents of the script and the code I suggest as a replacement so that
the motivation behind each change is clear.  Of course, please feel free
to refute my comments.

While obviously I am not going to insist on anyone signing up with
GitHub, I think this publicly available link will make reviewing the
suggested changes easy:

    https://github.com/gentoo/gentoo/pull/2477/commits/019a5fab1920a755b86e75423032858281b56af0?diff=split

For simplicity, I would suggest to first read my comments pertaining to
the current version of the script (the left side) and then the
explanations for selected parts of the replacement script (the right
side).

I have also attached the entire suggested replacement script to this
bug.

Please let me know what you guys think.

[1] https://github.com/gentoo/gentoo/pull/2477/
Comment 1 Justin Bronder (RETIRED) gentoo-dev 2016-10-28 13:00:24 UTC
Merged, thanks for bearing with me moving slowly!