Bug 59645 – Portage 2.0.51_pre17 RESTRICT=maketest logic ambigious

• Status: RESOLVED FIXED
• Product: Portage Development

[Description Daniel Black (RETIRED) 2004-08-06 16:21:10 UTC]

In the dyn_test function of ebuild.sh the RESTRICT=maketest will cause the src_test function to be skipped. A FEATURE=-maketest will also make the src_test to be skipped.

Imho this is far too ambigious and confusing. Maybe a RESTRICT=notest would be more consistant with other RESTRICT.

While I think of man 5 ebuild doesn't include maketest or whatever you change it too. You've impliemented the code for it may as well let people know its there to use.

[Comment 1 SpanKY 2004-08-09 23:20:42 UTC]

i think we should standardize all the RESTRICT stuff to be no*

[Comment 2 Nicholas Jones (RETIRED) 2004-08-15 15:17:21 UTC]

Actually I was planning on the opposite.
Everything forward. I hate double negatives.

You RESTRICT maketest even if you have the FEATURE maketest enabled.

You RESTRICT fetch. RESTRICTing nofetch is weird.

[Comment 3 SpanKY 2004-08-17 20:10:27 UTC]

works for me so long as we do have a standard

[Comment 4 Daniel Black (RETIRED) 2004-08-21 17:17:57 UTC]

ok Nick - I'm starting to follow your logic. As long as its consistant I'm happy.

[Comment 5 Nicholas Jones (RETIRED) 2004-09-24 20:05:13 UTC]

Spork. Yes.