Created attachment 448504 [details, diff] Patch fixing the wrong locale name. When installing Newsbeuter, the locale file is named newsbeuter-<version>.mo, however at run-time Newsbeuter search for the file newsbeuter.mo. I supply a patch that correct this by changing the value of PACKAGE to ${P} during the install phase instead of ${PF}.
Comment on attachment 448504 [details, diff] Patch fixing the wrong locale name. diff --git a/Makefile b/Makefile index ed13fe8..787af1b 100644 --- a/Makefile +++ b/Makefile @@ -214,8 +214,8 @@ install-mo: mo-files lang=`echo $$mofile | sed 's/\.mo$$//'`; \ dir=$(DESTDIR)$(localedir)/$$lang/LC_MESSAGES; \ $(MKDIR) $$dir ; \ - $(INSTALL) -m 644 $$mof $$dir/$(PACKAGE).mo ; \ - echo "Installing $$mofile as $$dir/$(PACKAGE).mo" ; \ + $(INSTALL) -m 644 $$mof $$dir/$(NEWSBEUTER).mo ; \ + echo "Installing $$mofile as $$dir/$(NEWSBEUTER).mo" ; \ done uninstall-mo: @@ -223,8 +223,8 @@ uninstall-mo: mofile=`basename $$mof` ; \ lang=`echo $$mofile | sed 's/\.mo$$//'`; \ dir=$(DESTDIR)$(localedir)/$$lang/LC_MESSAGES; \ - $(RM) -f $$dir/$(PACKAGE).mo ; \ - echo "Uninstalling $$dir/$(PACKAGE).mo" ; \ + $(RM) -f $$dir/$(NEWSBEUTER).mo ; \ + echo "Uninstalling $$dir/$(NEWSBEUTER).mo" ; \ done # tests and coverage reports
Can you open a pull request for this upstream?
(In reply to Tim Harder from comment #2) > Can you open a pull request for this upstream? Why can't we use the docdir variable instead of the PACKAGE one ? It doesn't change the name of the locale file and you can install the docs in the right place by setting it to "/usr/share/doc/${PF}".
(In reply to Thibaut Quentin from comment #3) > (In reply to Tim Harder from comment #2) > > Can you open a pull request for this upstream? > > Why can't we use the docdir variable instead of the PACKAGE one ? It doesn't > change the name of the locale file and you can install the docs in the right > place by setting it to "/usr/share/doc/${PF}". Yep, that makes sense. Fixed in 2.9-r2, thanks.
