595448 – Don't force rsync usage of --progress or --quiet when syncing

Bug 595448 - Don't force rsync usage of --progress or --quiet when syncing

Summary: Don't force rsync usage of --progress or --quiet when syncing

Status:	UNCONFIRMED

Alias:	None

Product:	Portage Development
Classification:	Unclassified
Component:	Enhancement/Feature Requests (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	Portage team

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2016-09-28 20:18 UTC by Austen Adler
Modified:	2016-09-28 21:06 UTC (History)
CC List:	0 users

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Austen Adler 2016-09-28 20:18:36 UTC

Under pym/portage/sync/modules/rsync/rsync.py in _rsync_opts_extend, Portage will check if --quiet is used. If it is, it will append --quiet to the rsync opts. If it is not, Portage will append --verbose and --progress flag to rsync. This will break the rsync flag --info=progress2. 

Reproducible: Always

Steps to Reproduce:
1. Add --info=progress2 to PORTAGE_RSYNC_EXTRA_OPTS
2. Ensure PORTAGE_RSYNC_OPTS does not include --quiet or --verbose
3. Run emaint sync -a
Actual Results:  
If --quiet is used, there is no rsync output while syncing. Otherwise, each file that was synced will print a new line and its progress will be shown. 

Expected Results:  
The --info=progress2 flag works as expected (only one line is printed out showing the overall progress of the transfer)

I suggest moving --verbose into PORTAGE_RSYNC_OPTS and removing the `if "--quiet" in opts:` check completely.

Comment 1 Austen Adler 2016-09-28 21:06:58 UTC

There is a workaround: setting `PORTAGE_RSYNC_EXTRA_OPTS="--no-progress --no-verbose --no-quiet"` will override the options set by portage.